Lap Tran
4a2301b077
CI / build (push) Has been cancelled
- Archive 79 completed framework-dev tasks from tasks/ -> tasks/complete/ - status.py: add --cleanup-done and --install-cleanup-schedule commands - Add scripts/automaton-cleanup.sh for periodic task archiving - Dashboard: rename 'Background' tab -> 'Agent', 'Cleanup' agent -> 'Completed Task Archiver', remove redundant group headers and pill badges, dim inactive agent placeholders - .rules.md: add Self-Documenting UI Names rule - New tests: test_cleanup_done.py, expanded test_app.py and test_task.py
23 lines
1.4 KiB
Markdown
23 lines
1.4 KiB
Markdown
# Implementation: fix-test-plan-phase-mapping
|
|
|
|
## Bug
|
|
Both `status.py:_infer_state_from_artifacts()` and the dashboard's `determine_task_state()` mapped `TEST_PLAN.md` to the `implement` phase. But `TEST_PLAN.md` is produced during the `test_design` phase, not `implement`. This caused:
|
|
- `--upgrade` to bootstrap incorrect `.state` for tasks with TEST_PLAN.md
|
|
- Dashboard to show `IMPLEMENT` instead of `TEST_DESIGN` for tasks that have a test plan but no implementation yet
|
|
|
|
## Fix
|
|
Changed the mapping in both locations:
|
|
1. `scripts/status.py:348-349`: `TEST_PLAN.md` → `test_design` (was `implement`)
|
|
2. `automaton/dashboard/core/task.py:548-549`: `TEST_PLAN.md` → `TaskState.TEST_DESIGN` (was `TaskState.IMPLEMENT`)
|
|
|
|
## Files Changed
|
|
- `scripts/status.py` (line 348-349): Changed return value from `"implement"` to `"test_design"`
|
|
- `automaton/dashboard/core/task.py` (line 548-549): Changed return from `TaskState.IMPLEMENT` to `TaskState.TEST_DESIGN`
|
|
- `tests/test_task.py`: Updated `test_implementation_from_test_plan` and `test_test_plan_shows_implement` to assert `TEST_DESIGN` instead of `IMPLEMENT`
|
|
|
|
## Tests
|
|
- `test_implementation_from_test_plan`: Now asserts `TaskState.TEST_DESIGN`
|
|
- `test_test_plan_shows_test_design` (renamed from `test_test_plan_shows_implement`): Asserts `TaskState.TEST_DESIGN`
|
|
- `test_test_plan_maps_to_test_design` in `test_status.py`: Verifies `--upgrade` infers `test_design` for TEST_PLAN.md
|
|
- All 249 tests pass
|