Lap Tran
bc7daf8590
- **Restore 82 completed tasks** from tasks/complete/ back to tasks/ top level (all <7 days old per the cleanup policy; premature bulk archive was fixed). - **Dashboard: fix scroll-reset on auto-refresh** — renderBoard rebuilds the board via innerHTML every 2s, destroying each column-body's scrollTop. Now snapshots column-body scrollTop + board.scrollLeft + view.scrollTop before rebuild and restores after (matched by PHASE_GROUPS index). - **Dashboard UI additions** (pre-existing unstaged work): approval section cards, transition buttons, inline artifact editor (textarea for writing missing SPEC/VERDICT/etc from the detail modal). - **Bind ornith as Implement model** — config.md: Model explicit to omlx/Ornith-1.0-35B-4bit-mlx, context window 32768. Interactive autopilot already used ornith via opencode default; now explicit. - **Fix cleanup stub** — automaton-cleanup.sh had a stale --project arg pointing at a pytest temp dir (test isolation leak). Rewired to point at ~/.automaton. - **Fix plist-isolation test** — test asserted host plist doesn't exist, but a real install creates it. Now snapshots mtime before run, asserts unchanged after (only a write during the test counts as bleed). - **New Playwright smoke test** (tests/test_dashboard_ui.py) — 2 tests: board renders tasks, column scroll survives auto-refresh tick. Verified the test fails without the scroll fix (scrollTop resets to 0). Skipped via importorskip when playwright is absent (main CI stays green). - **Clarify SI loop scope in README** — new-project onboarding section documents the framework-scoped self-improvement loop and options (leave/pause/create project loop). - **CHANGELOG** documents all changes including the known model-divergence gap (mde tasks marked complete but per-role model binding was never implemented).
29 lines
1.3 KiB
Markdown
29 lines
1.3 KiB
Markdown
# VERDICT: move-completed-tasks-to-complete-folder
|
|
|
|
## Task
|
|
|
|
On `--transition complete`, move the task directory from `tasks/<name>/` to `tasks/complete/<name>/`. Add `_task_dir` fallback. Keep `--list` and `--audit` excluding completed tasks.
|
|
|
|
## Deliverables Review
|
|
|
|
| Requirement | Status | Evidence |
|
|
|---|---|---|
|
|
| R1: `_task_dir` fallback | DONE | `scripts/status.py` lines 246-249, 3 tests |
|
|
| R2: `cmd_transition` moves on complete | DONE | `scripts/status.py` lines 601-612, 5 tests |
|
|
| R3: `_all_task_dirs` unchanged | DONE | 1 test confirms exclusion |
|
|
| R4: Tests | DONE | 9 tests in `tests/test_move_completed.py`, all passing |
|
|
| R5: Documentation | DONE | CHANGELOG updated |
|
|
|
|
## Quality Assessment
|
|
|
|
- **Test coverage:** 9 new tests, all passing. Full suite 433 passed (was 424). No regressions.
|
|
- **Code quality:** Minimal change (15 lines added to status.py). Cleanly separates `complete` path from regular transition path.
|
|
- **Race condition fix:** Rename before state write ensures no stale directory creation on concurrent completion.
|
|
- **Security:** Adversarial review found no exploitable vulnerabilities.
|
|
|
|
## Verdict
|
|
|
|
**APPROVED -- ready for complete.**
|
|
|
|
All 5 requirements fully implemented, tested, and documented. This completes all 9 bootstrap tasks for loop engineering v1.
|