Lap Tran
bc7daf8590
- **Restore 82 completed tasks** from tasks/complete/ back to tasks/ top level (all <7 days old per the cleanup policy; premature bulk archive was fixed). - **Dashboard: fix scroll-reset on auto-refresh** — renderBoard rebuilds the board via innerHTML every 2s, destroying each column-body's scrollTop. Now snapshots column-body scrollTop + board.scrollLeft + view.scrollTop before rebuild and restores after (matched by PHASE_GROUPS index). - **Dashboard UI additions** (pre-existing unstaged work): approval section cards, transition buttons, inline artifact editor (textarea for writing missing SPEC/VERDICT/etc from the detail modal). - **Bind ornith as Implement model** — config.md: Model explicit to omlx/Ornith-1.0-35B-4bit-mlx, context window 32768. Interactive autopilot already used ornith via opencode default; now explicit. - **Fix cleanup stub** — automaton-cleanup.sh had a stale --project arg pointing at a pytest temp dir (test isolation leak). Rewired to point at ~/.automaton. - **Fix plist-isolation test** — test asserted host plist doesn't exist, but a real install creates it. Now snapshots mtime before run, asserts unchanged after (only a write during the test counts as bleed). - **New Playwright smoke test** (tests/test_dashboard_ui.py) — 2 tests: board renders tasks, column scroll survives auto-refresh tick. Verified the test fails without the scroll fix (scrollTop resets to 0). Skipped via importorskip when playwright is absent (main CI stays green). - **Clarify SI loop scope in README** — new-project onboarding section documents the framework-scoped self-improvement loop and options (leave/pause/create project loop). - **CHANGELOG** documents all changes including the known model-divergence gap (mde tasks marked complete but per-role model binding was never implemented).
45 lines
2.5 KiB
Markdown
45 lines
2.5 KiB
Markdown
# VERDICT: add-blast-radius-scheduler
|
|
|
|
**Status: PASS**
|
|
|
|
Task delivers per-loop git worktree creation in the runner, closing the last gap in the blast-radius enforcement chain. With this task, the runner ensures a worktree exists before spawning any role, the drift gate checks it, and `--can-edit --loop-worktree` scopes file edits to it.
|
|
|
|
## Requirement coverage
|
|
|
|
| Req | Status | Tests |
|
|
|-----|--------|-------|
|
|
| R1 _ensure_worktree | delivered | TestEnsureWorktree (4) |
|
|
| R2 graceful degradation | delivered | TestGracefulDegradation (3) |
|
|
| R3 cmd_tick integration | delivered | TestTickIntegration (3) |
|
|
| R4 branch already exists | delivered | TestBranchExists (1) |
|
|
| R5 state consistency | delivered | TestStateConsistency (2) |
|
|
| R6 platform paths | delivered | TestPlatformPaths (1) |
|
|
| R7 doc updates | delivered | technical.md + CHANGELOG |
|
|
| R8 tests | delivered | 15 tests + regression |
|
|
|
|
Tests: 15 new. Full suite: **369 passed** (was 354 + 15 new). No regressions.
|
|
|
|
## Blast-radius enforcement chain -- complete
|
|
|
|
1. **Worktree creation** (this task): runner creates `<loop>/worktree` on branch `loop/<name>`.
|
|
2. **Drift detection** (task 2): `--check-gate` runs `git diff --name-only main...HEAD` restricted to `file_scope`.
|
|
3. **File scope enforcement** (task 2): `--can-edit --loop [--loop-worktree]` checks paths against `blast_radius.file_scope`.
|
|
4. **Graceful fallback** (this task): non-git projects fall back to project root with WARNING; drift gate skips when `worktree_path` is null.
|
|
|
|
## Agnosticism preserved
|
|
|
|
- **Git-agnostic**: falls back gracefully when git is unavailable. Loops on non-git projects work (edits go to primary checkout).
|
|
- **Platform-agnostic**: `pathlib.Path` for all path construction. Git handles OS-specific path normalization.
|
|
- **Model-agnostic**: no model inspection. Worktree creation is infrastructure, not model behavior.
|
|
|
|
## Hardening items deferred
|
|
|
|
1. Worktree GC / pruning (BACKLOG `worktree-gc`) -> v1.1.
|
|
2. `--no-worktree` CLI flag for `--create-loop` -> v1.1 (convenience sugar).
|
|
3. `blast_radius.base_branch` parameterization -> v1.1.
|
|
4. fcntl lock on worktree creation (TOCTOU A4) -> v1.1 (same item as `add-status-brakes` A6).
|
|
|
|
## Resolution
|
|
|
|
**PASS -- proceed to `complete`.** Task 5 completes the blast-radius enforcement chain. The runner now creates worktrees, the drift gate checks them, and `--can-edit` scopes file edits. Remaining tasks: 6 (templates-onboarding), 7 (self-improvement-loop), 8 (install-update-flow), 9 (move-completed-tasks).
|