Lap Tran
bc7daf8590
- **Restore 82 completed tasks** from tasks/complete/ back to tasks/ top level (all <7 days old per the cleanup policy; premature bulk archive was fixed). - **Dashboard: fix scroll-reset on auto-refresh** — renderBoard rebuilds the board via innerHTML every 2s, destroying each column-body's scrollTop. Now snapshots column-body scrollTop + board.scrollLeft + view.scrollTop before rebuild and restores after (matched by PHASE_GROUPS index). - **Dashboard UI additions** (pre-existing unstaged work): approval section cards, transition buttons, inline artifact editor (textarea for writing missing SPEC/VERDICT/etc from the detail modal). - **Bind ornith as Implement model** — config.md: Model explicit to omlx/Ornith-1.0-35B-4bit-mlx, context window 32768. Interactive autopilot already used ornith via opencode default; now explicit. - **Fix cleanup stub** — automaton-cleanup.sh had a stale --project arg pointing at a pytest temp dir (test isolation leak). Rewired to point at ~/.automaton. - **Fix plist-isolation test** — test asserted host plist doesn't exist, but a real install creates it. Now snapshots mtime before run, asserts unchanged after (only a write during the test counts as bleed). - **New Playwright smoke test** (tests/test_dashboard_ui.py) — 2 tests: board renders tasks, column scroll survives auto-refresh tick. Verified the test fails without the scroll fix (scrollTop resets to 0). Skipped via importorskip when playwright is absent (main CI stays green). - **Clarify SI loop scope in README** — new-project onboarding section documents the framework-scoped self-improvement loop and options (leave/pause/create project loop). - **CHANGELOG** documents all changes including the known model-divergence gap (mde tasks marked complete but per-role model binding was never implemented).
24 lines
2.3 KiB
Markdown
24 lines
2.3 KiB
Markdown
# Adversarial Bug Report: project-scoping-enforcement
|
|
|
|
## Summary
|
|
Adversarial review of the project scoping enforcement implementation. While the code changes are correct and well-tested, the process violation (implementing before tasking) reveals a deeper trust model issue.
|
|
|
|
## Bugs Found
|
|
|
|
### Bug 1: Agent can bypass the entire framework by editing files directly (Critical)
|
|
- **Severity**: Critical
|
|
- **Description**: All enforcement in the framework is prompt-based or tool-based (`status.py`). But nothing prevents an agent from directly editing `scripts/status.py` or any other file without a task. The `--can-edit` check only works if the agent *chooses* to call it. This is the same category of issue as the one we were fixing — the framework trusts the agent to follow its own rules.
|
|
- **Suggested Fix**: This is inherent to prompt-driven frameworks. The fix is discipline, not code. However, we could add a git pre-commit hook that checks for `.state` file existence for modified files.
|
|
|
|
### Bug 2: `_infer_state_from_artifacts` heuristic is still slightly wrong (Low)
|
|
- **Severity**: Low
|
|
- **Description**: In `_infer_state_from_artifacts`, when `SPEC.md` exists without `BUG_REPORT.md`, it returns `bug_find` instead of `research`. The logic at line 284 (`if "SPEC.md" in artifacts and "BUG_REPORT.md" not in artifacts: return "bug_find"`) is incorrect — a task with only SPEC.md should be in `research` phase. However, since this heuristic is now only used by `--upgrade` (for migrating pre-v2.0 tasks), the impact is limited — the upgrade might assign a slightly wrong phase that the user can manually correct in `.state`.
|
|
- **Suggested Fix**: Change line 284 to `if "SPEC.md" in artifacts and "BUG_REPORT.md" not in artifacts and "IMPLEMENTATION.md" not in artifacts: return "research"`
|
|
|
|
### Bug 3: `cmd_validate_folder` still uses `_infer_state_from_artifacts` after `.state` exists (Low)
|
|
- **Severity**: Low
|
|
- **Description**: After confirming `.state` exists, `cmd_validate_folder` reads it and then falls back to `_infer_state_from_artifacts` if the read returns None (line 538). This shouldn't happen in practice — if `.state` exists, `_read_state` should return a value. But the fallback is unnecessary.
|
|
- **Suggested Fix**: Remove the fallback and error instead.
|
|
|
|
## Score
|
|
+5 (Bug 1 is a known limitation, Bug 2 and 3 are minor) |