Lap Tran
bc7daf8590
- **Restore 82 completed tasks** from tasks/complete/ back to tasks/ top level (all <7 days old per the cleanup policy; premature bulk archive was fixed). - **Dashboard: fix scroll-reset on auto-refresh** — renderBoard rebuilds the board via innerHTML every 2s, destroying each column-body's scrollTop. Now snapshots column-body scrollTop + board.scrollLeft + view.scrollTop before rebuild and restores after (matched by PHASE_GROUPS index). - **Dashboard UI additions** (pre-existing unstaged work): approval section cards, transition buttons, inline artifact editor (textarea for writing missing SPEC/VERDICT/etc from the detail modal). - **Bind ornith as Implement model** — config.md: Model explicit to omlx/Ornith-1.0-35B-4bit-mlx, context window 32768. Interactive autopilot already used ornith via opencode default; now explicit. - **Fix cleanup stub** — automaton-cleanup.sh had a stale --project arg pointing at a pytest temp dir (test isolation leak). Rewired to point at ~/.automaton. - **Fix plist-isolation test** — test asserted host plist doesn't exist, but a real install creates it. Now snapshots mtime before run, asserts unchanged after (only a write during the test counts as bleed). - **New Playwright smoke test** (tests/test_dashboard_ui.py) — 2 tests: board renders tasks, column scroll survives auto-refresh tick. Verified the test fails without the scroll fix (scrollTop resets to 0). Skipped via importorskip when playwright is absent (main CI stays green). - **Clarify SI loop scope in README** — new-project onboarding section documents the framework-scoped self-improvement loop and options (leave/pause/create project loop). - **CHANGELOG** documents all changes including the known model-divergence gap (mde tasks marked complete but per-role model binding was never implemented).
23 lines
1.1 KiB
Markdown
23 lines
1.1 KiB
Markdown
# Adversarial Bug Report: parametrize-base-branch
|
|
|
|
## A1 — Git injection via base_branch value
|
|
|
|
`base_branch` values like `"; rm -rf /"` or `"main\norigin/main"` are passed through to `subprocess.run` in list mode. The entire value is a single argv element — no shell expansion, no injection. Git will attempt to resolve the string as a revision name and fail (fatal: bad revision), which triggers the WARNING-skip path. No exploit.
|
|
|
|
**Verdict**: no vector. List-mode subprocess.run is safe by construction.
|
|
|
|
## A2 — Non-string base_branch (int, bool) coerce to string
|
|
|
|
`42` → `"42"`, `True` → `"True"`. Both are valid git ref names (a tag named `42` or `True` would resolve). The WARNING notifies the operator. No crash, no silent misbehavior.
|
|
|
|
**Verdict**: acceptable. The WARNING is a signal to fix the config.
|
|
|
|
## A3 — Empty base_branch falls back to main
|
|
|
|
`""` → `"main"` with WARNING. Operator typed it intentionally or accidentally; either way the drift gate works on `main`. No data loss.
|
|
|
|
**Verdict**: correct per D-B4.
|
|
|
|
## No BLOCKERS
|
|
|
|
Proceed to doc_review. |