IMPLEMENTATION: fix-install-update-flow

Summary

Fixed 5 issues in the install/update flow: hardcoded git URL, .venv cwd bug, Windows venv path, hook copy-vs-symlink inconsistency, and missing --version smoke test.

Changes

R1 -- User-supplied git URL (D11)

scripts/install.sh: Replaced hardcoded http://10.37.0.86:3003/hermes/automaton with GIT_URL="${1:-}". If empty, prints usage with irreversibility warning and exits 1. The if [ -d "$FRAMEWORK_DIR" ] check now exit 0 instead of falling through to else.

R2 -- Fix `.venv` cwd bug

scripts/install.sh: Moved venv setup to use $FRAMEWORK_DIR/.venv instead of relative .venv. Changed requirements.txt to $FRAMEWORK_DIR/requirements.txt.

R3 -- Windows venv path

scripts/install.sh: Added platform-aware venv Python detection:

$FRAMEWORK_DIR/.venv/bin/python3 (Unix)
$FRAMEWORK_DIR/.venv/Scripts/python.exe (Windows)
Fallback: python3

Uses "$VENV_PY" -m pip instead of .venv/bin/pip for cross-platform compatibility.

R4 -- Hook copy-vs-symlink consistency

scripts/update.sh: Changed ln -sf "$HOOK_SRC" "$HOOK_DST" to cp "$HOOK_SRC" "$HOOK_DST" + chmod +x "$HOOK_DST".
scripts/upgrade.sh: Replaced all ln -sf and symlink-checking logic (readlink, -L) with cp + chmod +x. Simplified the hook-exists warning to point to install-hooks.sh.

R5 -- `--version` smoke test

scripts/install.sh: Added python3 "$FRAMEWORK_DIR/scripts/status.py" --version || echo "WARNING: ..." after self-improvement loop bootstrap.

R6 -- Tests

tests/test_install_update_flow.py: 15 tests across 4 classes:

TestInstallShGitUrl (4 tests): git URL required, no hardcoded URL, usage message, irreversibility warning
TestInstallShVenv (4 tests): venv in framework dir, Windows path, -m pip, no relative venv
TestInstallShVersionCheck (1 test): version check present
TestHookConsistency (6 tests): update.sh uses cp, upgrade.sh uses cp, install-hooks.sh uses cp, chmod present, no symlink check

R7 -- Documentation

CHANGELOG.md: task 8 entry
README.md: updated install instructions

Verification

bash -n scripts/install.sh scripts/update.sh scripts/upgrade.sh -- OK
python3 -m pytest tests/test_install_update_flow.py -v -- 15 passed
python3 -m pytest tests/ -q -- 424 passed (409 + 15 new)

2.3 KiB Raw Blame History