Lap Tran
81ccf548e5
CI / build (push) Has been cancelled
Batch 1 (High severity): - Bug 1: --audit cat3 now checks .automaton/tasks/ paths - Bug 4: Verdict PASS/FAIL uses structured ## Status: line parsing - Bug 5: register-guards.sh checks .json/.jsonc, writes plugin key, strips comments - Bug 7: --can-edit/--scope-check path prefix uses os.sep boundary Batch 2 (Medium/Low severity): - Bug 2: migrate-project.sh find command parentheses for -prune binding - Bug 3: vram_detect model prefix matching with known-suffix whitelist - Bug 6: dashboard reads .state file before artifact heuristic fallback - Bug 8: removed wildcard CORS, added security headers (nosniff, DENY) - Bug 9: stale-task detection uses .state.lastedit instead of .state mtime - Bug 10: TEST_PLAN.md maps to test_design (was implement) 249 tests pass (up from 235). All 10 tasks driven through full workflow to completion.
14 lines
589 B
Markdown
14 lines
589 B
Markdown
# Code Review: fix-migrate-find-precedence
|
|
|
|
## Reviewed Files
|
|
- `scripts/migrate-project.sh` (line 108)
|
|
|
|
## Changes
|
|
Added parentheses around `-name` tests in `find` command to ensure `-prune` binds to the entire OR-group.
|
|
|
|
## Verdict: PASS
|
|
|
|
The fix is correct and minimal. In POSIX `find`, `-a` (AND) has higher precedence than `-o` (OR), so without parentheses, `-prune` only applies to the last `-name` test. The parentheses ensure `-prune` applies to all three directories (`.git`, `node_modules`, `.automaton`).
|
|
|
|
Verified with `bash -n scripts/migrate-project.sh` — syntax is valid.
|