CI / build (push) Has been cancelled
- Archive 79 completed framework-dev tasks from tasks/ -> tasks/complete/ - status.py: add --cleanup-done and --install-cleanup-schedule commands - Add scripts/automaton-cleanup.sh for periodic task archiving - Dashboard: rename 'Background' tab -> 'Agent', 'Cleanup' agent -> 'Completed Task Archiver', remove redundant group headers and pill badges, dim inactive agent placeholders - .rules.md: add Self-Documenting UI Names rule - New tests: test_cleanup_done.py, expanded test_app.py and test_task.py
1.1 KiB
1.1 KiB
Code Review: fix-test-plan-phase-mapping
Reviewed Files
scripts/status.py(line 348-349:_infer_state_from_artifacts())automaton/dashboard/core/task.py(line 548-549:determine_task_state())tests/test_task.py
Changes
Changed TEST_PLAN.md mapping from implement → test_design in both status.py and dashboard task.py.
Analysis
- Correctness:
TEST_PLAN.mdis produced during thetest_designphase, notimplement. The workflow is:test_design→ (approval) →implement. TEST_PLAN.md is the output oftest_design, so it should map totest_design. - Consistency: Both
status.pyand dashboardtask.pynow use the same mapping - Test updates: Existing tests updated to assert
TEST_DESIGNinstead ofIMPLEMENT, and new test added for--upgradeinference - No regression: Tasks with both TEST_PLAN.md and IMPLEMENTATION.md still correctly map to
code_review(because IMPLEMENTATION.md is checked first)
Verdict: PASS
The fix is correct, minimal, and consistent across both enforcement and dashboard code.