Lap Tran
bc7daf8590
- **Restore 82 completed tasks** from tasks/complete/ back to tasks/ top level (all <7 days old per the cleanup policy; premature bulk archive was fixed). - **Dashboard: fix scroll-reset on auto-refresh** — renderBoard rebuilds the board via innerHTML every 2s, destroying each column-body's scrollTop. Now snapshots column-body scrollTop + board.scrollLeft + view.scrollTop before rebuild and restores after (matched by PHASE_GROUPS index). - **Dashboard UI additions** (pre-existing unstaged work): approval section cards, transition buttons, inline artifact editor (textarea for writing missing SPEC/VERDICT/etc from the detail modal). - **Bind ornith as Implement model** — config.md: Model explicit to omlx/Ornith-1.0-35B-4bit-mlx, context window 32768. Interactive autopilot already used ornith via opencode default; now explicit. - **Fix cleanup stub** — automaton-cleanup.sh had a stale --project arg pointing at a pytest temp dir (test isolation leak). Rewired to point at ~/.automaton. - **Fix plist-isolation test** — test asserted host plist doesn't exist, but a real install creates it. Now snapshots mtime before run, asserts unchanged after (only a write during the test counts as bleed). - **New Playwright smoke test** (tests/test_dashboard_ui.py) — 2 tests: board renders tasks, column scroll survives auto-refresh tick. Verified the test fails without the scroll fix (scrollTop resets to 0). Skipped via importorskip when playwright is absent (main CI stays green). - **Clarify SI loop scope in README** — new-project onboarding section documents the framework-scoped self-improvement loop and options (leave/pause/create project loop). - **CHANGELOG** documents all changes including the known model-divergence gap (mde tasks marked complete but per-role model binding was never implemented).
1.6 KiB
Adversarial Bug Report: add-outputs-retention
Probed _get_retention and _gc_outputs with non-contract inputs.
A1 — retention as float
_get_retention({"outputs": {"retention": 3.14}}) → int(3.14) = 3. Not garbage but truncating. Acceptable (float is a numeric type; int() rounds toward zero). Not a regression.
A2 — retention as bool
_get_retention({"outputs": {"retention": True}}) → int(True) = 1. A user who sets retention: true intending "unlimited" gets 1 (wrong — they wanted 0). But bool is technically a subclass of int in Python; int(True) = 1 is documented behavior. Acceptable edge case — the user would need to write JSON true, which json.loads reads as True. Not blocking; int(True) = 1 is a narrow retention but valid.
A3 — retention string "inf" falls back to 20
_get_retention({"outputs": {"retention": "inf"}}) → int("inf") raises ValueError → caught → 20 with WARNING. Correct per SPEC D-O4.
A4 — GC handles large gaps in tick indices
Files tick1-*.json and tick100-*.json with nothing in between: max_seen=100, retention=20, cutoff=100-20+1=81. Deletes tick1- but keeps tick100-. Correct — the gap is intentional (maybe intermittent ticks). Not a bug.
A5 — Non-tick files tick-nope.md preserved
Hyphen-no-number prefix tick-nope.md doesn't match ^tick(\d+)-. Preserved. Correct per D-O6.
A6 — Empty outputs dir
_gc_outputs on dir with 0 files or missing dir returns cleanly. No crash. Confirmed.
No BLOCKERS
All adversarial cases produce deterministic documented results. Proceed to doc_review.