Lap Tran
81ccf548e5
CI / build (push) Has been cancelled
Batch 1 (High severity): - Bug 1: --audit cat3 now checks .automaton/tasks/ paths - Bug 4: Verdict PASS/FAIL uses structured ## Status: line parsing - Bug 5: register-guards.sh checks .json/.jsonc, writes plugin key, strips comments - Bug 7: --can-edit/--scope-check path prefix uses os.sep boundary Batch 2 (Medium/Low severity): - Bug 2: migrate-project.sh find command parentheses for -prune binding - Bug 3: vram_detect model prefix matching with known-suffix whitelist - Bug 6: dashboard reads .state file before artifact heuristic fallback - Bug 8: removed wildcard CORS, added security headers (nosniff, DENY) - Bug 9: stale-task detection uses .state.lastedit instead of .state mtime - Bug 10: TEST_PLAN.md maps to test_design (was implement) 249 tests pass (up from 235). All 10 tasks driven through full workflow to completion.
21 lines
848 B
Markdown
21 lines
848 B
Markdown
# Bug Report: fix-register-guards
|
|
|
|
## Summary
|
|
The fix addresses all three bugs (wrong filename, wrong key, JSONC parsing). One minor cosmetic issue found and fixed during review.
|
|
|
|
## Bugs Found
|
|
No remaining bugs found.
|
|
|
|
## Verification
|
|
- Config detection now checks both `.json` and `.jsonc` — correct.
|
|
- Writes to `plugin` (singular) key — matches opencode config schema.
|
|
- JSONC comment stripping via `re.sub(r'//.*?$', '', text)` handles line comments.
|
|
- Manual install hint uses hardcoded path when no config detected (fixed during review).
|
|
- `bash -n scripts/register-guards.sh` passes.
|
|
|
|
## Note
|
|
The comment-stripping regex does not handle `//` inside string values (e.g., URLs). This is acceptable for opencode config files which typically don't contain such values, and is strictly better than the previous complete failure.
|
|
|
|
## Score
|
|
0
|