Lap Tran
4a2301b077
CI / build (push) Has been cancelled
- Archive 79 completed framework-dev tasks from tasks/ -> tasks/complete/ - status.py: add --cleanup-done and --install-cleanup-schedule commands - Add scripts/automaton-cleanup.sh for periodic task archiving - Dashboard: rename 'Background' tab -> 'Agent', 'Cleanup' agent -> 'Completed Task Archiver', remove redundant group headers and pill badges, dim inactive agent placeholders - .rules.md: add Self-Documenting UI Names rule - New tests: test_cleanup_done.py, expanded test_app.py and test_task.py
17 lines
946 B
Markdown
17 lines
946 B
Markdown
# Bug Report — harden-enforcement-layers
|
|
|
|
## Review Scope
|
|
Pre-push hook, install-hooks.sh, register-guards.sh, prompt modifications, contract updates, install/update/upgrade scripts, system-prompt.md.
|
|
|
|
## Findings
|
|
|
|
### No Critical Bugs Found
|
|
All scripts are syntactically correct (bash). The pre-push hook correctly calls `status.py --can-edit` with `--json` flag and blocks non-zero exit codes. The install-hooks.sh properly handles missing source files. The register-guards.sh correctly detects opencode config and pi binary.
|
|
|
|
### Minor Observations
|
|
- `register-guards.sh` line 30 uses Python inline with `$OPENCODE_CONFIG` directly inside a Python string — this could break if the path contains special characters
|
|
- `update.sh` hooks installation only runs if `git rev-parse` succeeds but doesn't check if the hook already exists (it checks `[ ! -f "$HOOK_DST" ]` which is safe)
|
|
|
|
## Verdict
|
|
No blocking bugs. Ready for adversarial review.
|