Lap Tran
4a2301b077
CI / build (push) Has been cancelled
- Archive 79 completed framework-dev tasks from tasks/ -> tasks/complete/ - status.py: add --cleanup-done and --install-cleanup-schedule commands - Add scripts/automaton-cleanup.sh for periodic task archiving - Dashboard: rename 'Background' tab -> 'Agent', 'Cleanup' agent -> 'Completed Task Archiver', remove redundant group headers and pill badges, dim inactive agent placeholders - .rules.md: add Self-Documenting UI Names rule - New tests: test_cleanup_done.py, expanded test_app.py and test_task.py
17 lines
779 B
Markdown
17 lines
779 B
Markdown
# Bug Report — port-pi-guard
|
|
|
|
## Review Scope
|
|
Pi dev guard plugin (guard.ts, package.json), integration in register-guards.sh and harness-integration.md.
|
|
|
|
## Findings
|
|
|
|
### No Critical Bugs Found
|
|
The guard.ts properly implements the pi ExtensionAPI pattern with `pi.on("tool_call", ...)`. It correctly intercepts edit/write/bash tools, calls status.py, and returns block responses. The fallback to allowing when status.py is unavailable is reasonable (fail-open for offline scenarios).
|
|
|
|
### Minor Observations
|
|
- Lines 38-40 contain unreachable dead code (the import is shadowed by the child_process import below)
|
|
- The bash tool regex check (`\b(write|tee|cp|mv|sed\b.*-i|dd\b.*of=)\b`) could miss some write patterns
|
|
|
|
## Verdict
|
|
No blocking bugs. Ready for adversarial review.
|