Lap Tran
bc7daf8590
- **Restore 82 completed tasks** from tasks/complete/ back to tasks/ top level (all <7 days old per the cleanup policy; premature bulk archive was fixed). - **Dashboard: fix scroll-reset on auto-refresh** — renderBoard rebuilds the board via innerHTML every 2s, destroying each column-body's scrollTop. Now snapshots column-body scrollTop + board.scrollLeft + view.scrollTop before rebuild and restores after (matched by PHASE_GROUPS index). - **Dashboard UI additions** (pre-existing unstaged work): approval section cards, transition buttons, inline artifact editor (textarea for writing missing SPEC/VERDICT/etc from the detail modal). - **Bind ornith as Implement model** — config.md: Model explicit to omlx/Ornith-1.0-35B-4bit-mlx, context window 32768. Interactive autopilot already used ornith via opencode default; now explicit. - **Fix cleanup stub** — automaton-cleanup.sh had a stale --project arg pointing at a pytest temp dir (test isolation leak). Rewired to point at ~/.automaton. - **Fix plist-isolation test** — test asserted host plist doesn't exist, but a real install creates it. Now snapshots mtime before run, asserts unchanged after (only a write during the test counts as bleed). - **New Playwright smoke test** (tests/test_dashboard_ui.py) — 2 tests: board renders tasks, column scroll survives auto-refresh tick. Verified the test fails without the scroll fix (scrollTop resets to 0). Skipped via importorskip when playwright is absent (main CI stays green). - **Clarify SI loop scope in README** — new-project onboarding section documents the framework-scoped self-improvement loop and options (leave/pause/create project loop). - **CHANGELOG** documents all changes including the known model-divergence gap (mde tasks marked complete but per-role model binding was never implemented).
51 lines
2.2 KiB
Markdown
51 lines
2.2 KiB
Markdown
# SPEC: move-completed-tasks-to-complete-folder
|
|
|
|
## Context
|
|
|
|
When a task transitions to `complete`, its directory remains in `tasks/<name>/` alongside active tasks. This clutters `--list` and `--audit`. The fix: move completed task directories to `tasks/complete/<name>/` when `--transition complete` is called.
|
|
|
|
## Requirements
|
|
|
|
### R1 -- `_task_dir` fallback
|
|
|
|
Modify `_task_dir(task_name, project)` in `scripts/status.py` to check `tasks/complete/<name>` as a fallback when `tasks/<name>` doesn't exist:
|
|
|
|
```python
|
|
task_path = base / task_name
|
|
if not task_path.exists():
|
|
completed = base / "complete" / task_name
|
|
if completed.exists():
|
|
return completed
|
|
return task_path
|
|
```
|
|
|
|
This ensures `--task <name>`, `--transition`, `--approve`, and other commands that call `_task_dir` still work for completed tasks.
|
|
|
|
### R2 -- `cmd_transition` moves task directory
|
|
|
|
After `_write_state(task_path, target)` in `cmd_transition`, add: if `target == "complete"`, compute the tasks root directory and move `task_path` to `tasks/complete/<name>/`. Create `tasks/complete/` if it doesn't exist. Print a message confirming the move.
|
|
|
|
### R3 -- `_all_task_dirs` unchanged
|
|
|
|
Do NOT scan `tasks/complete/` in `_all_task_dirs`. Completed tasks are out of sight from `--list` and `--audit`.
|
|
|
|
### R4 -- Tests
|
|
|
|
Write `tests/test_move_completed.py` covering:
|
|
1. `test_complete_moves_dir` -- simulate `--transition complete` on a task, verify the dir moves to `tasks/complete/<name>/`.
|
|
2. `test_task_dir_fallback` -- verify `_task_dir` returns the completed path when task is in `tasks/complete/`.
|
|
3. `test_all_task_dirs_excludes_completed` -- verify `_all_task_dirs` does NOT include completed tasks.
|
|
4. `test_create_task_refuses_completed` -- verify `--create-task` with the same name as a completed task is refused.
|
|
5. `test_transition_refuses_from_complete` -- verify `--transition` from `complete` is refused.
|
|
6. `test_complete_dir_created_on_first_move` -- verify `tasks/complete/` is created if it doesn't exist.
|
|
|
|
### R5 -- Documentation
|
|
|
|
- `CHANGELOG.md` under `[unreleased]`
|
|
|
|
## Verification
|
|
|
|
- `python3 -m py_compile scripts/status.py`
|
|
- `python3 -m pytest tests/test_move_completed.py -v`
|
|
- `python3 -m pytest tests/ -q` -- full suite green
|