Lap Tran
bc7daf8590
- **Restore 82 completed tasks** from tasks/complete/ back to tasks/ top level (all <7 days old per the cleanup policy; premature bulk archive was fixed). - **Dashboard: fix scroll-reset on auto-refresh** — renderBoard rebuilds the board via innerHTML every 2s, destroying each column-body's scrollTop. Now snapshots column-body scrollTop + board.scrollLeft + view.scrollTop before rebuild and restores after (matched by PHASE_GROUPS index). - **Dashboard UI additions** (pre-existing unstaged work): approval section cards, transition buttons, inline artifact editor (textarea for writing missing SPEC/VERDICT/etc from the detail modal). - **Bind ornith as Implement model** — config.md: Model explicit to omlx/Ornith-1.0-35B-4bit-mlx, context window 32768. Interactive autopilot already used ornith via opencode default; now explicit. - **Fix cleanup stub** — automaton-cleanup.sh had a stale --project arg pointing at a pytest temp dir (test isolation leak). Rewired to point at ~/.automaton. - **Fix plist-isolation test** — test asserted host plist doesn't exist, but a real install creates it. Now snapshots mtime before run, asserts unchanged after (only a write during the test counts as bleed). - **New Playwright smoke test** (tests/test_dashboard_ui.py) — 2 tests: board renders tasks, column scroll survives auto-refresh tick. Verified the test fails without the scroll fix (scrollTop resets to 0). Skipped via importorskip when playwright is absent (main CI stays green). - **Clarify SI loop scope in README** — new-project onboarding section documents the framework-scoped self-improvement loop and options (leave/pause/create project loop). - **CHANGELOG** documents all changes including the known model-divergence gap (mde tasks marked complete but per-role model binding was never implemented).
22 lines
1.2 KiB
Markdown
22 lines
1.2 KiB
Markdown
# Adversarial Bug Report: Dashboard Task Review and Approval
|
|
|
|
## Deep Review
|
|
The review API writes REVIEW.md to the task folder. Submissions are POST with status + comment.
|
|
|
|
## Potential Issues
|
|
1. **No authentication**: Any HTTP client can submit reviews. The dashboard is localhost-only by default, but `--host 0.0.0.0` exposes the review API without auth.
|
|
|
|
2. **No CSRF protection**: POST endpoint accepts JSON from any origin. Mitigated by same-origin policy and no cookies/auth.
|
|
|
|
3. **Path traversal in task name**: Task name is URL-decoded but no `../` check. An attacker could write REVIEW.md outside the tasks directory. Fixed below.
|
|
|
|
4. **Comment injection**: Comment content is written directly to REVIEW.md without escaping. If REVIEW.md is ever consumed by a markdown renderer, injected markdown could be an issue.
|
|
|
|
## Security Fix: Path traversal
|
|
The `_handle_review` endpoint writes to `project_root / ".automaton" / "tasks" / task_name / self.REVIEW_FILE`. If task_name contains `../`, the review file could be written outside the tasks directory. Add a path traversal check.
|
|
|
|
## Security Fix Applied
|
|
Added path traversal validation to task name in _handle_review and _get_review_status.
|
|
|
|
## Verdict: PASS (with security fix applied)
|