Lap Tran
bc7daf8590
- **Restore 82 completed tasks** from tasks/complete/ back to tasks/ top level (all <7 days old per the cleanup policy; premature bulk archive was fixed). - **Dashboard: fix scroll-reset on auto-refresh** — renderBoard rebuilds the board via innerHTML every 2s, destroying each column-body's scrollTop. Now snapshots column-body scrollTop + board.scrollLeft + view.scrollTop before rebuild and restores after (matched by PHASE_GROUPS index). - **Dashboard UI additions** (pre-existing unstaged work): approval section cards, transition buttons, inline artifact editor (textarea for writing missing SPEC/VERDICT/etc from the detail modal). - **Bind ornith as Implement model** — config.md: Model explicit to omlx/Ornith-1.0-35B-4bit-mlx, context window 32768. Interactive autopilot already used ornith via opencode default; now explicit. - **Fix cleanup stub** — automaton-cleanup.sh had a stale --project arg pointing at a pytest temp dir (test isolation leak). Rewired to point at ~/.automaton. - **Fix plist-isolation test** — test asserted host plist doesn't exist, but a real install creates it. Now snapshots mtime before run, asserts unchanged after (only a write during the test counts as bleed). - **New Playwright smoke test** (tests/test_dashboard_ui.py) — 2 tests: board renders tasks, column scroll survives auto-refresh tick. Verified the test fails without the scroll fix (scrollTop resets to 0). Skipped via importorskip when playwright is absent (main CI stays green). - **Clarify SI loop scope in README** — new-project onboarding section documents the framework-scoped self-improvement loop and options (leave/pause/create project loop). - **CHANGELOG** documents all changes including the known model-divergence gap (mde tasks marked complete but per-role model binding was never implemented).
37 lines
2.8 KiB
Markdown
37 lines
2.8 KiB
Markdown
# Bug Report: add-status-brakes
|
|
|
|
Adversarial probing of the brakes layer against the five loop-death modes listed in `design/loops/functional.md` (drift, runaway, bad verifier, resource burn, undetected halt).
|
|
|
|
## Bugs found
|
|
|
|
None blocking. The code passed all six gates exercised in `tests/test_status_brakes.py`. Below are minor robustness observations (informational, not blockers).
|
|
|
|
## Observations (non-blocking)
|
|
|
|
### O1 — `_loop_untracked_hint` mentions `--upgrade-loops` which doesn't exist yet
|
|
`_loop_untracked_hint` references a future `--upgrade-loops` command. Until it ships (v1.1), users will see the hint but the command won't exist. The hint is advisory; the actionable path (`--create-loop`) is also named. Acceptable for v1.
|
|
|
|
### O2 — `cmd_install_schedule` on Linux does not re-install via `_enable_schedule`
|
|
`_enable_schedule` for Linux is a no-op branch (`pass`). `--resume-loop` therefore does not restart a Linux cron block that was stripped by `--pause-loop`. Darwin path renames `*.plist.disabled` back, Windows path re-runs `schtasks /run`. Linux asymmetry is a known gap; the next tick will still fire per the original cron line if it survived. For full symmetry, `_enable_schedule` on Linux should re-invoke the install code. Minor; not blocking — runner's `--check-gate` is the runtime enforcement, not the scheduler.
|
|
|
|
### O3 — `_gate_worktree_drift` runs `git diff main...HEAD`
|
|
Hard-codes `main` as the integration branch. Projects on `master`/`trunk` would show every file as out-of-scope (no `main` to diff against → git errors → gate skips with warning). Worth parameterizing per loop config (`blast_radius.base_branch`) in task 5 when worktree creation lands. For v1, the warning path is the correct fail-safe.
|
|
|
|
### O4 — `_disable_schedule` Linux path strips the cron block permanently
|
|
`--pause-loop` on Linux removes the cron block; `--resume-loop`'s Linux branch is a no-op. So a Linux user who pauses a loop loses their schedule. Mitigation: the user can re-run `--install-schedule` after resuming. Same as O2; tracked together.
|
|
|
|
### O5 — `cmd_check_gate` halts the loop when any gate returns a failure dict
|
|
Even informational gates (`budget_exhausted`) cause a halt write. Per D3 budget is "informational only (remote)". If we want it to **halt but not refuse continuation**, we'd need a softer "warn" verdict. Out of scope for v1; matches SPEC R5 wording ("first failure wins").
|
|
|
|
## No blocker bugs
|
|
|
|
All five loop-death modes are defended:
|
|
- **drift** → `_gate_worktree_drift` (R5)
|
|
- **runaway** → `_gate_iterations` (R5)
|
|
- **bad verifier** → `_gate_score_plateau` (R5)
|
|
- **resource burn** → `_gate_budget` (R5, remote-only informational)
|
|
- **undetected halt** → `cmd_transition` R8 refusal + `cmd_audit` Cat-6 + `cmd_check_gate` halt-write
|
|
|
|
## Verdict
|
|
|
|
PASS — proceed to adversarial_bug_find. |