Lap Tran
bc7daf8590
- **Restore 82 completed tasks** from tasks/complete/ back to tasks/ top level (all <7 days old per the cleanup policy; premature bulk archive was fixed). - **Dashboard: fix scroll-reset on auto-refresh** — renderBoard rebuilds the board via innerHTML every 2s, destroying each column-body's scrollTop. Now snapshots column-body scrollTop + board.scrollLeft + view.scrollTop before rebuild and restores after (matched by PHASE_GROUPS index). - **Dashboard UI additions** (pre-existing unstaged work): approval section cards, transition buttons, inline artifact editor (textarea for writing missing SPEC/VERDICT/etc from the detail modal). - **Bind ornith as Implement model** — config.md: Model explicit to omlx/Ornith-1.0-35B-4bit-mlx, context window 32768. Interactive autopilot already used ornith via opencode default; now explicit. - **Fix cleanup stub** — automaton-cleanup.sh had a stale --project arg pointing at a pytest temp dir (test isolation leak). Rewired to point at ~/.automaton. - **Fix plist-isolation test** — test asserted host plist doesn't exist, but a real install creates it. Now snapshots mtime before run, asserts unchanged after (only a write during the test counts as bleed). - **New Playwright smoke test** (tests/test_dashboard_ui.py) — 2 tests: board renders tasks, column scroll survives auto-refresh tick. Verified the test fails without the scroll fix (scrollTop resets to 0). Skipped via importorskip when playwright is absent (main CI stays green). - **Clarify SI loop scope in README** — new-project onboarding section documents the framework-scoped self-improvement loop and options (leave/pause/create project loop). - **CHANGELOG** documents all changes including the known model-divergence gap (mde tasks marked complete but per-role model binding was never implemented).
22 lines
1.1 KiB
Markdown
22 lines
1.1 KiB
Markdown
# Implementation: Harden Dashboard Security
|
|
|
|
## Summary
|
|
- Added CORS headers (`Access-Control-Allow-Origin`, `Methods`, `Headers`) to all API responses via `_send_json()` and `_send_error()`
|
|
- Added `do_OPTIONS` handler for CORS preflight requests
|
|
- Added `X-Content-Type-Options: nosniff` header to all responses
|
|
- Added `MAX_POST_BODY = 65536` (64KB) content-length limit on POST review endpoint
|
|
- Added `MAX_REVIEW_COMMENT_LENGTH = 4096` character limit on review comments
|
|
- Replaced inline `onclick` handlers in review buttons with `data-task`/`data-status` attributes + event delegation
|
|
- Applied `escapeHtml()` to `task.display_name` in `renderTaskCard()`
|
|
- Filesystem task name validation was already implemented in `fix-verdict-parsing` (R2 of this SPEC is done)
|
|
|
|
## Changes
|
|
- `automaton/dashboard/ui/app.py`: Added CORS headers, `do_OPTIONS`, content-length bounds, comment truncation
|
|
- `automaton/dashboard/html/dashboard.js`: Replaced onclick handlers with data attributes, escaped display_name
|
|
|
|
## Test Results
|
|
119 passed in 0.08s (full suite)
|
|
Dashboard starts and serves correct CORS headers on all API responses
|
|
|
|
## Blockers
|
|
None |