Lap Tran
bc7daf8590
- **Restore 82 completed tasks** from tasks/complete/ back to tasks/ top level (all <7 days old per the cleanup policy; premature bulk archive was fixed). - **Dashboard: fix scroll-reset on auto-refresh** — renderBoard rebuilds the board via innerHTML every 2s, destroying each column-body's scrollTop. Now snapshots column-body scrollTop + board.scrollLeft + view.scrollTop before rebuild and restores after (matched by PHASE_GROUPS index). - **Dashboard UI additions** (pre-existing unstaged work): approval section cards, transition buttons, inline artifact editor (textarea for writing missing SPEC/VERDICT/etc from the detail modal). - **Bind ornith as Implement model** — config.md: Model explicit to omlx/Ornith-1.0-35B-4bit-mlx, context window 32768. Interactive autopilot already used ornith via opencode default; now explicit. - **Fix cleanup stub** — automaton-cleanup.sh had a stale --project arg pointing at a pytest temp dir (test isolation leak). Rewired to point at ~/.automaton. - **Fix plist-isolation test** — test asserted host plist doesn't exist, but a real install creates it. Now snapshots mtime before run, asserts unchanged after (only a write during the test counts as bleed). - **New Playwright smoke test** (tests/test_dashboard_ui.py) — 2 tests: board renders tasks, column scroll survives auto-refresh tick. Verified the test fails without the scroll fix (scrollTop resets to 0). Skipped via importorskip when playwright is absent (main CI stays green). - **Clarify SI loop scope in README** — new-project onboarding section documents the framework-scoped self-improvement loop and options (leave/pause/create project loop). - **CHANGELOG** documents all changes including the known model-divergence gap (mde tasks marked complete but per-role model binding was never implemented).
33 lines
1.6 KiB
Markdown
33 lines
1.6 KiB
Markdown
# Implementation: add-claim-loop-task
|
|
|
|
## What was implemented
|
|
|
|
### `--claim-loop-task` subcommand (status.py)
|
|
|
|
New `--claim-loop-task <name> --task <taskname> [--project P]` command. Uses `_loop_lock` for serialization. Implementation steps:
|
|
|
|
1. Checks `.state.loop` exists (untracked → exit 2)
|
|
2. Scans all loops via `_all_loop_dirs()` — if another running/paused loop owns the task → exit 2 with `task_already_claimed:{other}`
|
|
3. If self owns the task → exit 0 (idempotent, no re-write)
|
|
4. If nobody owns it → sets `state["current_task"] = taskname`, writes `.state.loop`, exit 0
|
|
|
|
### Runner claim integration (loop-runner.py)
|
|
|
|
Step 3.5: After `_find_work` returns a candidate different from `state.current_task`, spawns `status.py --claim-loop-task` as a subprocess with `$AUTOMATON_NO_LOOP_LOCK=1` (same bypass as `_gate`). Non-zero exit → skip tick with `task_claimed_by_other_loop`.
|
|
|
|
Step 9.5: After orchestrator subprocess, re-reads task `.state`. If `complete` or `human_intervention` → `state["current_task"] = None` (releases claim).
|
|
|
|
## Files changed
|
|
|
|
- `scripts/status.py` — added `_claim_loop_task_impl`, `cmd_claim_loop_task`, `--claim-loop-task` arg + dispatch
|
|
- `scripts/loop-runner.py` — added step 3.5 (claim) and step 9.5 (release) in `cmd_tick`
|
|
|
|
## Tests
|
|
|
|
10 tests in `tests/test_claim_loop_task.py` covering:
|
|
- Claim succeeds (no owner), claim refused (other owner), claim idempotent (self owner)
|
|
- Untracked loop, missing task arg
|
|
- Paused loop's claim blocks new claim
|
|
- Self-healing race (refuse, release, re-claim succeeds)
|
|
- Release on `complete` and `human_intervention`, no release on `implement`
|