gitea
05c76852a2
CI / build (push) Has been cancelled
State Enforcement (v2.0):
- .state file as single source of truth for task phase
- Approval gates for research, decomposition, design, test_design
- status.py --transition refuses illegal phase transitions
- status.py --validate-folder detects out-of-order artifacts
- status.py --audit checks all tasks for violations
- status.py --create-task is the only valid way to create tasks
- Pre-v2.0 tasks without .state are UNTRACKED -- all commands refuse them
- New --upgrade command bootstraps .state files for existing tasks
Project Scoping:
- --project flag added to all status.py commands across 16+ files
- _find_project_dir errors instead of silently falling back to ~/.automaton/
- --scope-check marks framework files OUT_OF_SCOPE when working on a project
- Dashboard handlers use stored project_root instead of re-detecting from CWD
- Prompts reference ~/.automaton/scripts/vram_detect.py (not {project}/.automaton/)
Harness Integration:
- status.py --can-edit now supports project-level checks (no --task required)
- --can-edit --file checks file scope without --task
- --json output for machine-readable harness integration
- opencode plugin (plugins/automaton-guard/plugin.ts) intercepts edit/write
- Git pre-commit hook (scripts/git-hooks/pre-commit) blocks commits without task
- Formal integration contract (contracts/harness-integration.md)
Other:
- upgrade.sh delegates to status.py --upgrade instead of manual heuristics
- Phase prompts reference --project {project} for multi-project scoping
- 200 tests passing (14 new)
25 lines
1.4 KiB
Markdown
25 lines
1.4 KiB
Markdown
# Doc Review: fix-verdict-parsing
|
|
|
|
## Summary
|
|
Documentation review of the code changes for verdict parsing and state machine alignment.
|
|
|
|
## Documentation Plan Compliance
|
|
- N/A — No DESIGN.md existed for this task (it went straight from SPEC to implementation).
|
|
|
|
## Documentation Completeness
|
|
- `automaton/dashboard/core/task.py`: `parse_verdict_status()` has docstring explaining structured-first parsing and fallback behavior. ✓
|
|
- `tests/test_task.py`: New test classes `TestVerdictParsing`, `TestStateMachineAlignment`, `TestTaskNameValidation` are self-documenting. ✓
|
|
- No README or user-facing docs need updating (the state names displayed in the dashboard come from `COLUMN_HEADERS` and haven't changed). ✓
|
|
|
|
## Documentation Accuracy
|
|
- `CHANGELOG.md`: Needs an entry under `[unreleased]`. ✓ (to be added)
|
|
- `automaton/dashboard/core/task.py` docstring for `parse_verdict_status` accurately describes the structured-vs-fallback behavior. ✓
|
|
|
|
## Issues Found
|
|
### Issue 1: Verdict format not documented in referee prompt
|
|
- **Severity**: Medium
|
|
- **Description**: The referee prompt (`prompts/referee.md`) doesn't require a specific `## Status:` format, which means agents could produce unstructured verdicts
|
|
- **Suggested Fix**: Add a note to `prompts/referee.md` requiring the `## Status: PASS|FAIL|NEEDS_REVIEW` format. This is R6 in the SPEC.
|
|
|
|
## Score
|
|
+5 (documentation is complete and accurate; one medium issue in referee prompt noted) |