Lap Tran
bc7daf8590
- **Restore 82 completed tasks** from tasks/complete/ back to tasks/ top level (all <7 days old per the cleanup policy; premature bulk archive was fixed). - **Dashboard: fix scroll-reset on auto-refresh** — renderBoard rebuilds the board via innerHTML every 2s, destroying each column-body's scrollTop. Now snapshots column-body scrollTop + board.scrollLeft + view.scrollTop before rebuild and restores after (matched by PHASE_GROUPS index). - **Dashboard UI additions** (pre-existing unstaged work): approval section cards, transition buttons, inline artifact editor (textarea for writing missing SPEC/VERDICT/etc from the detail modal). - **Bind ornith as Implement model** — config.md: Model explicit to omlx/Ornith-1.0-35B-4bit-mlx, context window 32768. Interactive autopilot already used ornith via opencode default; now explicit. - **Fix cleanup stub** — automaton-cleanup.sh had a stale --project arg pointing at a pytest temp dir (test isolation leak). Rewired to point at ~/.automaton. - **Fix plist-isolation test** — test asserted host plist doesn't exist, but a real install creates it. Now snapshots mtime before run, asserts unchanged after (only a write during the test counts as bleed). - **New Playwright smoke test** (tests/test_dashboard_ui.py) — 2 tests: board renders tasks, column scroll survives auto-refresh tick. Verified the test fails without the scroll fix (scrollTop resets to 0). Skipped via importorskip when playwright is absent (main CI stays green). - **Clarify SI loop scope in README** — new-project onboarding section documents the framework-scoped self-improvement loop and options (leave/pause/create project loop). - **CHANGELOG** documents all changes including the known model-divergence gap (mde tasks marked complete but per-role model binding was never implemented).
30 lines
1.4 KiB
Markdown
30 lines
1.4 KiB
Markdown
# VERDICT: add-self-improvement-loop
|
|
|
|
## Task
|
|
|
|
Wire the self-improvement loop into `install.sh` (default-on for fresh installs) and `update.sh` (idempotent bootstrap for existing users), per D21.
|
|
|
|
## Deliverables Review
|
|
|
|
| Requirement | Status | Evidence |
|
|
|---|---|---|
|
|
| R1: install.sh creates and schedules loop | DONE | `scripts/install.sh` lines ~70-82, 5 tests in `TestInstallShWiring` |
|
|
| R2: update.sh idempotent bootstrap | DONE | `scripts/update.sh` lines ~61-70, 4 tests in `TestUpdateShWiring` |
|
|
| R3: Tests | DONE | 16 tests in `tests/test_self_improvement_loop.py`, all passing |
|
|
| R4: Documentation | DONE | CHANGELOG, README, technical.md section 9 updated |
|
|
|
|
## Quality Assessment
|
|
|
|
- **Test coverage:** 16 new tests, all passing. Full suite 409 passed (was 393). No regressions.
|
|
- **Shell syntax:** `bash -n` passes for both scripts.
|
|
- **Idempotency:** `update.sh` checks for existing loop dir before creating. `--create-loop` also refuses duplicates.
|
|
- **Non-fatal behavior:** `|| true` on both commands ensures framework works even if loop creation fails.
|
|
- **Security:** Adversarial review found no exploitable vulnerabilities.
|
|
- **Documentation:** All docs accurate and consistent.
|
|
|
|
## Verdict
|
|
|
|
**APPROVED -- ready for complete.**
|
|
|
|
All 4 requirements fully implemented, tested, and documented. The self-improvement loop is now default-on at install time (D21), with idempotent bootstrap for existing users.
|