Lap Tran
bc7daf8590
- **Restore 82 completed tasks** from tasks/complete/ back to tasks/ top level (all <7 days old per the cleanup policy; premature bulk archive was fixed). - **Dashboard: fix scroll-reset on auto-refresh** — renderBoard rebuilds the board via innerHTML every 2s, destroying each column-body's scrollTop. Now snapshots column-body scrollTop + board.scrollLeft + view.scrollTop before rebuild and restores after (matched by PHASE_GROUPS index). - **Dashboard UI additions** (pre-existing unstaged work): approval section cards, transition buttons, inline artifact editor (textarea for writing missing SPEC/VERDICT/etc from the detail modal). - **Bind ornith as Implement model** — config.md: Model explicit to omlx/Ornith-1.0-35B-4bit-mlx, context window 32768. Interactive autopilot already used ornith via opencode default; now explicit. - **Fix cleanup stub** — automaton-cleanup.sh had a stale --project arg pointing at a pytest temp dir (test isolation leak). Rewired to point at ~/.automaton. - **Fix plist-isolation test** — test asserted host plist doesn't exist, but a real install creates it. Now snapshots mtime before run, asserts unchanged after (only a write during the test counts as bleed). - **New Playwright smoke test** (tests/test_dashboard_ui.py) — 2 tests: board renders tasks, column scroll survives auto-refresh tick. Verified the test fails without the scroll fix (scrollTop resets to 0). Skipped via importorskip when playwright is absent (main CI stays green). - **Clarify SI loop scope in README** — new-project onboarding section documents the framework-scoped self-improvement loop and options (leave/pause/create project loop). - **CHANGELOG** documents all changes including the known model-divergence gap (mde tasks marked complete but per-role model binding was never implemented).
35 lines
1.3 KiB
Markdown
35 lines
1.3 KiB
Markdown
# Implementation: parametrize-base-branch
|
|
|
|
## SCOPE
|
|
|
|
Replace hardcoded `"main"` in `_gate_worktree_drift` with `blast_radius.base_branch` config field. Source: `add-status-brakes/BUG_REPORT.md` O3.
|
|
|
|
## FILES TOUCHED
|
|
|
|
- `scripts/status.py`
|
|
- Added `_base_branch(cfg) -> str`: reads `cfg.get("blast_radius", {}).get("base_branch")` → `"main"`.
|
|
- `None` (missing key) → `"main"` (silent).
|
|
- Empty string → `"main"` with stderr WARNING.
|
|
- Non-string type (int, bool, etc.) → `str(value)` with WARNING.
|
|
- `_gate_worktree_drift`: replaced `"main...HEAD"` with `f"{base}...HEAD"` where `base = _base_branch(cfg)`.
|
|
- `templates/loops/self-improvement/loop.json`: added `"base_branch": "main"` to `blast_radius`.
|
|
|
|
## BUGS FOUND
|
|
|
|
None. The bad-revision path and empty-file_scope checks are unchanged from v1.
|
|
|
|
## DECISIONS LOCKED
|
|
|
|
- D-B1: one base branch per loop (not a list).
|
|
- D-B2: default `"main"`.
|
|
- D-B3: bad-revision → WARNING skip (not halt), preserved from v1.
|
|
- D-B4: empty string → `"main"` with WARNING (not silent).
|
|
- D-B5: no backfill on v1 loops (helper default covers them).
|
|
- D-B6: tests mock `subprocess.run`.
|
|
- D-B7: template is the public-facing default.
|
|
|
|
## TESTS
|
|
|
|
New file `tests/test_base_branch.py` — 13 tests across 2 classes.
|
|
|
|
Test count: 495 passed (482 + 13). |