Lap Tran
bc7daf8590
- **Restore 82 completed tasks** from tasks/complete/ back to tasks/ top level (all <7 days old per the cleanup policy; premature bulk archive was fixed). - **Dashboard: fix scroll-reset on auto-refresh** — renderBoard rebuilds the board via innerHTML every 2s, destroying each column-body's scrollTop. Now snapshots column-body scrollTop + board.scrollLeft + view.scrollTop before rebuild and restores after (matched by PHASE_GROUPS index). - **Dashboard UI additions** (pre-existing unstaged work): approval section cards, transition buttons, inline artifact editor (textarea for writing missing SPEC/VERDICT/etc from the detail modal). - **Bind ornith as Implement model** — config.md: Model explicit to omlx/Ornith-1.0-35B-4bit-mlx, context window 32768. Interactive autopilot already used ornith via opencode default; now explicit. - **Fix cleanup stub** — automaton-cleanup.sh had a stale --project arg pointing at a pytest temp dir (test isolation leak). Rewired to point at ~/.automaton. - **Fix plist-isolation test** — test asserted host plist doesn't exist, but a real install creates it. Now snapshots mtime before run, asserts unchanged after (only a write during the test counts as bleed). - **New Playwright smoke test** (tests/test_dashboard_ui.py) — 2 tests: board renders tasks, column scroll survives auto-refresh tick. Verified the test fails without the scroll fix (scrollTop resets to 0). Skipped via importorskip when playwright is absent (main CI stays green). - **Clarify SI loop scope in README** — new-project onboarding section documents the framework-scoped self-improvement loop and options (leave/pause/create project loop). - **CHANGELOG** documents all changes including the known model-divergence gap (mde tasks marked complete but per-role model binding was never implemented).
25 lines
1.4 KiB
Markdown
25 lines
1.4 KiB
Markdown
# Implementation: fix-vram-model-prefix-match
|
|
|
|
## Bug
|
|
`_lookup_model_context()` in `vram_detect.py` used raw `startswith()` for model name matching, causing false positives like `phi-4` matching `phi-40` or `phi-4-mini-instruct` (a different model with different context window).
|
|
|
|
## Fix
|
|
Replaced the raw `startswith()` with a three-tier matching strategy:
|
|
1. **Exact match** — `name_lower == key_lower`
|
|
2. **Ollama parameter tag** — `name_lower.startswith(key_lower + ":")` (e.g. `deepseek-r1:7b` matches `deepseek-r1`)
|
|
3. **Known instruction-tuning suffix** — `name_lower.startswith(key_lower + "-")` only if the next segment is in `_KNOWN_MODEL_SUFFIXES = {"instruct", "chat", "it", "fp16", "f16", "bf16"}` (e.g. `llama-3.1-8b-instruct` matches `llama-3.1-8b`)
|
|
|
|
Keys are sorted by length descending so the most specific match wins first.
|
|
|
|
This prevents false matches:
|
|
- `phi-4-mini-instruct` → `mini` not in known suffixes → no match ✓
|
|
- `gpt-4o-foo-unknown` → `foo` not in known suffixes → no match ✓
|
|
- `phi-40` → no `:` or known-suffix separator → no match ✓
|
|
|
|
## Files Changed
|
|
- `scripts/vram_detect.py`: Added `_KNOWN_MODEL_SUFFIXES` set, rewrote `_lookup_model_context()` with three-tier matching
|
|
|
|
## Tests
|
|
- `test_lookup_model_context_no_false_prefix_match`: Asserts `phi-4-mini-instruct` and `gpt-4o-foo-unknown` return 0
|
|
- Existing `test_lookup_model_context_prefix_match` still passes (deepseek-r1:7b and llama-3.1-8b-instruct)
|