Lap Tran
bc7daf8590
- **Restore 82 completed tasks** from tasks/complete/ back to tasks/ top level (all <7 days old per the cleanup policy; premature bulk archive was fixed). - **Dashboard: fix scroll-reset on auto-refresh** — renderBoard rebuilds the board via innerHTML every 2s, destroying each column-body's scrollTop. Now snapshots column-body scrollTop + board.scrollLeft + view.scrollTop before rebuild and restores after (matched by PHASE_GROUPS index). - **Dashboard UI additions** (pre-existing unstaged work): approval section cards, transition buttons, inline artifact editor (textarea for writing missing SPEC/VERDICT/etc from the detail modal). - **Bind ornith as Implement model** — config.md: Model explicit to omlx/Ornith-1.0-35B-4bit-mlx, context window 32768. Interactive autopilot already used ornith via opencode default; now explicit. - **Fix cleanup stub** — automaton-cleanup.sh had a stale --project arg pointing at a pytest temp dir (test isolation leak). Rewired to point at ~/.automaton. - **Fix plist-isolation test** — test asserted host plist doesn't exist, but a real install creates it. Now snapshots mtime before run, asserts unchanged after (only a write during the test counts as bleed). - **New Playwright smoke test** (tests/test_dashboard_ui.py) — 2 tests: board renders tasks, column scroll survives auto-refresh tick. Verified the test fails without the scroll fix (scrollTop resets to 0). Skipped via importorskip when playwright is absent (main CI stays green). - **Clarify SI loop scope in README** — new-project onboarding section documents the framework-scoped self-improvement loop and options (leave/pause/create project loop). - **CHANGELOG** documents all changes including the known model-divergence gap (mde tasks marked complete but per-role model binding was never implemented).
14 lines
956 B
Markdown
14 lines
956 B
Markdown
# Code Review: fix-verdict-pass-inference
|
|
|
|
## Summary
|
|
Replaces fragile substring search with structured-line parsing, matching the dashboard's existing `parse_verdict_status()` approach.
|
|
|
|
## Findings
|
|
- **Correctness**: `_parse_verdict_status_line()` correctly looks for `## Status:` and `- **Status**:` headers, extracting the value after the colon. The `after_colon.upper()` comparison handles case variations.
|
|
- **Consistency**: The new helper mirrors `automaton/dashboard/core/task.py:parse_verdict_status()` — good alignment between enforcement layers.
|
|
- **Fallback**: Unparseable verdicts now return `"human_intervention"` instead of the old behavior (which would have returned `human_intervention` for anything without "PASS"). This is a safe default.
|
|
- **Edge case**: A verdict with `## Status: PASS` and "FAIL" in body correctly returns `complete` — the structured parse only looks at the status line.
|
|
|
|
## Verdict
|
|
APPROVED — no issues found.
|