Lap Tran
bc7daf8590
- **Restore 82 completed tasks** from tasks/complete/ back to tasks/ top level (all <7 days old per the cleanup policy; premature bulk archive was fixed). - **Dashboard: fix scroll-reset on auto-refresh** — renderBoard rebuilds the board via innerHTML every 2s, destroying each column-body's scrollTop. Now snapshots column-body scrollTop + board.scrollLeft + view.scrollTop before rebuild and restores after (matched by PHASE_GROUPS index). - **Dashboard UI additions** (pre-existing unstaged work): approval section cards, transition buttons, inline artifact editor (textarea for writing missing SPEC/VERDICT/etc from the detail modal). - **Bind ornith as Implement model** — config.md: Model explicit to omlx/Ornith-1.0-35B-4bit-mlx, context window 32768. Interactive autopilot already used ornith via opencode default; now explicit. - **Fix cleanup stub** — automaton-cleanup.sh had a stale --project arg pointing at a pytest temp dir (test isolation leak). Rewired to point at ~/.automaton. - **Fix plist-isolation test** — test asserted host plist doesn't exist, but a real install creates it. Now snapshots mtime before run, asserts unchanged after (only a write during the test counts as bleed). - **New Playwright smoke test** (tests/test_dashboard_ui.py) — 2 tests: board renders tasks, column scroll survives auto-refresh tick. Verified the test fails without the scroll fix (scrollTop resets to 0). Skipped via importorskip when playwright is absent (main CI stays green). - **Clarify SI loop scope in README** — new-project onboarding section documents the framework-scoped self-improvement loop and options (leave/pause/create project loop). - **CHANGELOG** documents all changes including the known model-divergence gap (mde tasks marked complete but per-role model binding was never implemented).
24 lines
2.6 KiB
Markdown
24 lines
2.6 KiB
Markdown
# Doc Review: fix-harness-command-template
|
|
|
|
Reviewed docs touched by or referring to the fix.
|
|
|
|
## Files reviewed
|
|
|
|
- `CHANGELOG.md` — added a new `### Fixed — harness command template (task fix-harness-command-template)` entry at the top of `[unreleased]` covering the fix, the new `{prompt_content}` token, backwards compat, the inline UnicodeDecodeError fix, harness-agnostic contract preservation, test scaffolding updates, and the 7 new tests. Also corrected the stale `add-loop-runner` v1 entry that mentioned the old `--prompt-file`/`--cwd` default — pointed readers at the v1.1 fix entry instead. Computed full-suite count as 440 (was 433; +7 new).
|
|
- `README.md` — updated the `harness.command` row in the loop.json fields table to mention `{prompt}`, `{prompt_content}`, `{cwd}` tokens and the override pattern for non-opencode harnesses (Pi Dev, aider, etc.).
|
|
- `design/loops/technical.md` §8 — rewritten to document the new default shape; added a per-token explanation table including `{prompt_content}`; added a `--model` override example for routing ticks to a local LLM (Qwen, etc.); added three non-opencode examples (Pi Dev, aider, generic shell wrapper); reaffirmed the D8 / harness-agnostic contract.
|
|
- `design/loops/technical.md` §9 — updated the self-improvement template's `harness.command` to the new default.
|
|
- `templates/loops/self-improvement/loop.json` — `harness.command` updated to the new default.
|
|
- `AGENTS.md` — no edits needed (the AGENTS.md loop runner bullet mentions the binary and the per-tick engine at a high level; doesn't reference the default command shape).
|
|
- `prompts/loop-*.md` — no edits needed (prompts are content; no flag references).
|
|
- `contracts/harness-integration.md` — no edits needed (covers pre-edit guard, not tick harness invocation).
|
|
- `plugins/automaton-guard-pi/` — no edits needed (pre-edit guard plugin; unaffected by tick harness command fix).
|
|
- `scripts/status.py` — no edits needed (status.py does not invoke the harness). `--install-schedule` writes a stub at the loop dir; the stub invokes `loop-runner.py --mode tick` which in turn invokes the harness. The runner's fix is what makes the chain work end-to-end.
|
|
|
|
## Cross-references checked
|
|
|
|
- `rg "prompt-file|--cwd" design/ templates/ scripts/ contracts/ README.md AGENTS.md` — only intentional references remain (in the `design/loops/technical.md` explanatory text mentioning that the old default had no `--prompt-file` flag, and in the Pi Dev / generic examples that use `--cwd` as a user-chosen flag for their harness). No stale references.
|
|
|
|
## Verdict
|
|
|
|
PASS — proceed to referee. |