Lap Tran
bc7daf8590
- **Restore 82 completed tasks** from tasks/complete/ back to tasks/ top level (all <7 days old per the cleanup policy; premature bulk archive was fixed). - **Dashboard: fix scroll-reset on auto-refresh** — renderBoard rebuilds the board via innerHTML every 2s, destroying each column-body's scrollTop. Now snapshots column-body scrollTop + board.scrollLeft + view.scrollTop before rebuild and restores after (matched by PHASE_GROUPS index). - **Dashboard UI additions** (pre-existing unstaged work): approval section cards, transition buttons, inline artifact editor (textarea for writing missing SPEC/VERDICT/etc from the detail modal). - **Bind ornith as Implement model** — config.md: Model explicit to omlx/Ornith-1.0-35B-4bit-mlx, context window 32768. Interactive autopilot already used ornith via opencode default; now explicit. - **Fix cleanup stub** — automaton-cleanup.sh had a stale --project arg pointing at a pytest temp dir (test isolation leak). Rewired to point at ~/.automaton. - **Fix plist-isolation test** — test asserted host plist doesn't exist, but a real install creates it. Now snapshots mtime before run, asserts unchanged after (only a write during the test counts as bleed). - **New Playwright smoke test** (tests/test_dashboard_ui.py) — 2 tests: board renders tasks, column scroll survives auto-refresh tick. Verified the test fails without the scroll fix (scrollTop resets to 0). Skipped via importorskip when playwright is absent (main CI stays green). - **Clarify SI loop scope in README** — new-project onboarding section documents the framework-scoped self-improvement loop and options (leave/pause/create project loop). - **CHANGELOG** documents all changes including the known model-divergence gap (mde tasks marked complete but per-role model binding was never implemented).
31 lines
1.3 KiB
Markdown
31 lines
1.3 KiB
Markdown
# Spec: fix-can-edit-path-prefix
|
|
|
|
## Problem
|
|
`--can-edit` and `--scope-check` in `scripts/status.py` use `str(file_path).startswith(proj_str)` to verify a file is within the project directory. String `startswith` matches sibling directories: `/home/user/project-evil/file.py` matches prefix `/home/user/project`. This allows editing files outside the project boundary.
|
|
|
|
Affected locations:
|
|
- `scripts/status.py:951` (`--can-edit --project --file`)
|
|
- `scripts/status.py:1004` (`--can-edit --task --file`, framework case)
|
|
- `scripts/status.py:1010` (`--can-edit --task --file`, regular project case)
|
|
- `scripts/status.py:1047` (`--scope-check`)
|
|
- `scripts/status.py:1052` (`--scope-check`, framework check)
|
|
|
|
## Fix
|
|
Append a trailing path separator to the prefix before comparison:
|
|
```python
|
|
str(file_path).startswith(proj_str + os.sep)
|
|
```
|
|
Or use `Path.relative_to()` which correctly resolves path boundaries:
|
|
```python
|
|
try:
|
|
file_path.relative_to(project_dir.resolve())
|
|
except ValueError:
|
|
# out of scope
|
|
```
|
|
|
|
## Acceptance Criteria
|
|
- A file in `/home/user/project-evil/` is correctly rejected as out-of-scope when project is `/home/user/project`
|
|
- A file in `/home/user/project/subdir/` is correctly accepted as in-scope
|
|
- Both framework and regular project cases work
|
|
- Add a test in `tests/test_status.py` covering the sibling-directory edge case
|