Files

T

Lap Tran bc7daf8590 Restore archived tasks, fix dashboard scroll-reset, bind ornith, add Playwright smoke test

- **Restore 82 completed tasks** from tasks/complete/ back to tasks/ top
  level (all <7 days old per the cleanup policy; premature bulk archive
  was fixed).
- **Dashboard: fix scroll-reset on auto-refresh** — renderBoard rebuilds
  the board via innerHTML every 2s, destroying each column-body's
  scrollTop. Now snapshots column-body scrollTop + board.scrollLeft +
  view.scrollTop before rebuild and restores after (matched by
  PHASE_GROUPS index).
- **Dashboard UI additions** (pre-existing unstaged work): approval
  section cards, transition buttons, inline artifact editor (textarea for
  writing missing SPEC/VERDICT/etc from the detail modal).
- **Bind ornith as Implement model** — config.md: Model explicit to
  omlx/Ornith-1.0-35B-4bit-mlx, context window 32768. Interactive
  autopilot already used ornith via opencode default; now explicit.
- **Fix cleanup stub** — automaton-cleanup.sh had a stale --project arg
  pointing at a pytest temp dir (test isolation leak). Rewired to point
  at ~/.automaton.
- **Fix plist-isolation test** — test asserted host plist doesn't exist,
  but a real install creates it. Now snapshots mtime before run, asserts
  unchanged after (only a write during the test counts as bleed).
- **New Playwright smoke test** (tests/test_dashboard_ui.py) — 2 tests:
  board renders tasks, column scroll survives auto-refresh tick.
  Verified the test fails without the scroll fix (scrollTop resets to 0).
  Skipped via importorskip when playwright is absent (main CI stays
  green).
- **Clarify SI loop scope in README** — new-project onboarding section
  documents the framework-scoped self-improvement loop and options
  (leave/pause/create project loop).
- **CHANGELOG** documents all changes including the known model-divergence
  gap (mde tasks marked complete but per-role model binding was never
  implemented).

2026-06-26 10:05:18 -04:00

892 B

Raw Permalink Blame History

Code Review: fix-can-edit-path-prefix

Summary

Fixes path prefix matching at 5 locations to prevent sibling-directory bypass.

Findings

Correctness: str(file_path).startswith(proj_str + os.sep) or str(file_path) == proj_str correctly handles both files inside the directory and the directory itself. The os.sep ensures the boundary is a path separator, preventing /home/user/project-evil from matching /home/user/project.
Consistency: All 5 locations use the same pattern — good.
Edge cases:
- A file exactly at proj_str (the project root itself) is handled by the == proj_str clause.
- Symlinks: Path.resolve() is called on file_path, so symlinks are resolved before comparison. This is correct.
Tests: 3 tests cover the sibling-rejection, subdirectory-acceptance, and can-edit-task scenarios.

Verdict

APPROVED — no issues found.

892 B Raw Permalink Blame History

Code Review: fix-can-edit-path-prefix

Summary

Findings

Verdict

892 B

Raw Permalink Blame History