16 lines
892 B
Markdown
16 lines
892 B
Markdown
|
# Code Review: fix-can-edit-path-prefix
|
||
|
|
|
||
|
|
## Summary
|
||
|
|
Fixes path prefix matching at 5 locations to prevent sibling-directory bypass.
|
||
|
|
|
||
|
|
## Findings
|
||
|
|
- **Correctness**: `str(file_path).startswith(proj_str + os.sep) or str(file_path) == proj_str` correctly handles both files inside the directory and the directory itself. The `os.sep` ensures the boundary is a path separator, preventing `/home/user/project-evil` from matching `/home/user/project`.
|
||
|
|
- **Consistency**: All 5 locations use the same pattern — good.
|
||
|
|
- **Edge cases**:
|
||
|
|
- A file exactly at `proj_str` (the project root itself) is handled by the `== proj_str` clause.
|
||
|
|
- Symlinks: `Path.resolve()` is called on `file_path`, so symlinks are resolved before comparison. This is correct.
|
||
|
|
- **Tests**: 3 tests cover the sibling-rejection, subdirectory-acceptance, and can-edit-task scenarios.
|
||
|
|
|
||
|
|
## Verdict
|
||
|
|
APPROVED — no issues found.
|