Lap Tran
bc7daf8590
- **Restore 82 completed tasks** from tasks/complete/ back to tasks/ top level (all <7 days old per the cleanup policy; premature bulk archive was fixed). - **Dashboard: fix scroll-reset on auto-refresh** — renderBoard rebuilds the board via innerHTML every 2s, destroying each column-body's scrollTop. Now snapshots column-body scrollTop + board.scrollLeft + view.scrollTop before rebuild and restores after (matched by PHASE_GROUPS index). - **Dashboard UI additions** (pre-existing unstaged work): approval section cards, transition buttons, inline artifact editor (textarea for writing missing SPEC/VERDICT/etc from the detail modal). - **Bind ornith as Implement model** — config.md: Model explicit to omlx/Ornith-1.0-35B-4bit-mlx, context window 32768. Interactive autopilot already used ornith via opencode default; now explicit. - **Fix cleanup stub** — automaton-cleanup.sh had a stale --project arg pointing at a pytest temp dir (test isolation leak). Rewired to point at ~/.automaton. - **Fix plist-isolation test** — test asserted host plist doesn't exist, but a real install creates it. Now snapshots mtime before run, asserts unchanged after (only a write during the test counts as bleed). - **New Playwright smoke test** (tests/test_dashboard_ui.py) — 2 tests: board renders tasks, column scroll survives auto-refresh tick. Verified the test fails without the scroll fix (scrollTop resets to 0). Skipped via importorskip when playwright is absent (main CI stays green). - **Clarify SI loop scope in README** — new-project onboarding section documents the framework-scoped self-improvement loop and options (leave/pause/create project loop). - **CHANGELOG** documents all changes including the known model-divergence gap (mde tasks marked complete but per-role model binding was never implemented).
43 lines
3.0 KiB
Markdown
43 lines
3.0 KiB
Markdown
# VERDICT: add-loop-templates-onboarding
|
|
|
|
## Task
|
|
|
|
Implement prompt-file token substitution in the loop runner, create three loop role prompts (`loop-implement.md`, `loop-verifier.md`, `loop-orchestrate.md`), fill in both loop templates, create the self-improvement template, and add onboarding documentation.
|
|
|
|
## Deliverables Review
|
|
|
|
| Requirement | Status | Evidence |
|
|
|---|---|---|
|
|
| R1: `_resolve_prompt` with token substitution | DONE | `scripts/loop-runner.py:248-303`, 4 tests in `TestResolvePrompt` |
|
|
| R2: `prompts/loop-implement.md` | DONE | File created, 2 tests in `TestPromptFiles` |
|
|
| R3: `prompts/loop-verifier.md` | DONE | File created, 3 tests in `TestPromptFiles` |
|
|
| R4: `prompts/loop-orchestrate.md` | DONE | File created, 2 tests in `TestPromptFiles` |
|
|
| R5: ci-triage template roles filled | DONE | `templates/loops/ci-triage/loop.json`, 1 test in `TestCiTriageTemplate` |
|
|
| R6: self-improvement template created | DONE | `templates/loops/self-improvement/loop.json`, 5 tests in `TestSelfImprovementTemplate` |
|
|
| R7: README onboarding section | DONE | `README.md` "Loop Engineering" section with Quick Start, Tick Cycle, Configuration, Monitoring, Halt/Resume |
|
|
| R8: `tests/test_loop_templates.py` | DONE | 18 tests (target was 12-16; exceeded) |
|
|
| R9: CHANGELOG and technical.md | DONE | `CHANGELOG.md` task 6 entry, `design/loops/technical.md` section 8 updated |
|
|
|
|
## Quality Assessment
|
|
|
|
- **Test coverage:** 18 new tests, all passing. Full suite 393 passed (was 369). No regressions.
|
|
- **Backward compatibility:** `_invoke_harness` new params are optional. Existing tests updated to use non-existent prompt refs so `_resolve_prompt` fallback path is exercised. No breaking changes.
|
|
- **Code quality:** `_resolve_prompt` is clean, well-structured, handles all edge cases (missing file, missing artifact, empty prompt_ref, missing outputs dir). Follows existing code conventions.
|
|
- **Documentation:** README onboarding section is comprehensive. technical.md section 8 documents the prompt resolution flow. CHANGELOG is detailed.
|
|
- **Security:** Adversarial review found no exploitable vulnerabilities. Path traversal is mitigated by trusted input. Token injection is not possible (single-pass substitution). Large artifact DoS is mitigated by context floor gate.
|
|
|
|
## Pipeline Artifacts
|
|
|
|
- SPEC.md -- written and approved
|
|
- IMPLEMENTATION.md -- written
|
|
- CODE_REVIEW.md -- written, approved
|
|
- BUG_REPORT.md -- written (CLEAN, 2 LOW + 1 INFO)
|
|
- ADVERSARIAL_BUG_REPORT.md -- written (CLEAN, no exploitable vulnerabilities)
|
|
- DOC_REVIEW.md -- written (APPROVED)
|
|
|
|
## Verdict
|
|
|
|
**APPROVED -- ready for complete.**
|
|
|
|
All 9 requirements (R1-R9) are fully implemented, tested, and documented. The task delivers the critical missing piece of loop engineering v1: prompt-file token substitution that closes the feedback loop between ticks. The three loop role prompts provide the LLM instructions for the Implement/Verify/Orchestrate cycle. The self-improvement template enables the framework to improve itself via audit-driven loops.
|