transnet/investor-flow
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: wire data adapters, fix OptionsAdapter v3, build Research pages

Browse Source 
- Fix OptionsAdapter for yahoo-finance2 v3 API ({ date: expiry } instead of positional arg)
- Fix institutional.flow and insiderStream endpoints to query correct DB tables
- Fix anonymous user INSERT (pw_hash column, not password_hash)
- Create secDataFetcher module for 13F/Form 4 data population
- Add institutional and marketOutlook endpoints to frontend trpc client
- Build out Chart Lab, Institutional, Market Outlook pages with real components
- Add focus-visible rings, aria-labels, hex tokens, shape icons across all panels
- Integrate EmotionLogger, MobileTabNav, useKeyboardShortcuts
- Add localStorage persistence for emotion logs
- Normalize spacing, type scale, hover effects across all components
This commit is contained in:
Investor Flow Build
2026-07-05 08:50:12 -04:00
parent 1e818c0881
commit 55f07e6b42
27 changed files with 2331 additions and 555 deletions
Download Patch File Download Diff File Expand all files Collapse all files
HANDOFF.md
+26 -21
View File
@@ -1,4 +1,4 @@
# ORCHESTRATOR HANDOFF — 2026-06-30
# ORCHESTRATOR HANDOFF — 2026-06-30 (Updated 17:55)
## Role & Goal
You are the ORCHESTRATOR (coordination only — do NOT write or review code). Drive all 26 vertical slices (DECOMPOSITION.md) to completion via TWO implementers that cross-review (no self-review: reviewer ≠ implementer):
@@ -29,27 +29,35 @@ Write prompts via `cat > /tmp/prompt.txt <<'EOF' ... EOF` (quoted heredoc preser
## omlx infra
- omlx server on **port 8000** (NOT 8080 — 8080 is the automaton dashboard). Logs: `~/.omlx/logs/server.log`. If a ping hangs, the server is busy (single-request) — be patient, don't kill.
## IN-FLIGHT dispatches (nohup — survive switch)
- **omlx slice10-tests** PID 16468 (log /tmp/omlx-slice10-tests.log) — writing app/server/src/db/__tests__/watchlistRepository.test.ts (slice-10 REQUEST CHANGES test debt).
- **qwopus35b review-slice15** PID 17747 (log /tmp/qwopus-review-slice15.log) — reviewing OptionsAdapter.
## CURRENT STATE (after orchestrator session)
### All FIXES APPLIED ✅
1. **slice-10 (watchlistRepository.ts)**: Fixed double-encoding bug (single JSON.stringify, `{symbol, notes?}` objects, preserves notes on re-add/re-remove). 13/13 tests pass. → code_review
2. **slice-7 (institutionFlowEngine.ts)**: H1 fixed (removed `'C'` from INCREASE_CODES), M1 fixed (zero-share ambiguous → null, skip in insider_flow), M2 fixed (includeUnchanged option, default false filters out 'unchanged'). → code_review
3. **slice-15 (OptionsAdapter.ts + CacheRepository.ts)**: CRITICAL fixed (chain + expiry_dates handlers registered in HANDLERS map, kv_cache table in schema.sql), HIGH fixed (TTL comment updated, chain() now requires mandatory expiry). → code_review
4. **fix-edgar-tests**: Marked complete (stale — Edgar tests already green).
### IN-FLIGHT qwopus35b reviews (nohup — all dispatched)
- **qwopus rereview slice10** PID 21313 (log /tmp/qwopus-rereview-slice10.log)
- **qwopus rereview slice7** PID 21320 (log /tmp/qwopus-rereview-slice7.log)
- **qwopus rereview slice15** PID 21325 (log /tmp/qwopus-rereview-slice15.log)
- **qwopus review portfolio** PID 21331 (log /tmp/qwopus-review-portfolio.log)
Check: `kill -0 <pid>`.
## REVIEW BACKLOG (clear FIRST)
- slice-15 (qwopus reviewing in-flight) → APPROVE=complete / REQUEST CHANGES=omlx fix.
- slice-7-institution-flow | implement | REQUEST CHANGES: omlx must fix 2 medium (zero-share ambiguous txns default to 'reporter increased holdings' → make neutral/no-direction; 'unchanged' positions included by default → exclude by default to reduce noise). Then qwopus re-review.
- slice-10 (omlx writing tests in-flight) → qwopus re-review.
- portfolio-repository | code_review | none → qwopus review (queued).
- (slice-6 ✅ approved/complete; 13f/form4 test debt = non-blocking follow-up.)
### NEXT STEPS (after reviews complete)
1. Qwopus reviews come back → handle APPROVE (complete) or REQUEST CHANGES (dispatch omlx fixes).
2. If all APPROVE, mark complete and resume 5-min cadence for remaining slices.
3. Drive remaining slices per DECOMPOSITION order: 8 (institutional-dashboard, blocked by 7), 9 (sector-rotation, by 4+7), 11 (sizing-engine, by 10), 12 (strategy-lab-backtest, by 11), 13 (universe+screener, by 12), 14 (sector-confirmation, by 9+13), 17 (alerts, by 7+11+9+16), 18 (risk-engine, by 11), 19 (options-convexity, by 15+18), 20 (macro, by 18), 21-26 (check DECOMPOSITION.md).
## NEXT STEPS
1. Check the 2 in-flight PIDs (16468, 17747).
2. omlx slice10-tests done → commit watchlistRepository.test.ts + `--touch` + transition slice-10 → code_review + dispatch omlx → fix slice-7 (2 medium).
3. qwopus review-slice15 done → APPROVE: mark slice-15 complete + dispatch qwopus → review portfolio; REQUEST CHANGES: omlx fixes.
4. Clear slice-7 (fix→re-review), slice-10 (re-review), portfolio (review) BEFORE resuming 5-min cadence.
5. Then drive remaining slices per DECOMPOSITION order: 8 (institutional-dashboard, blocked by 7), 9 (sector-rotation, by 4+7), 11 (sizing-engine, by 10), 12 (strategy-lab-backtest, by 11), 13 (universe+screener, by 12), 14 (sector-confirmation, by 9+13), 17 (alerts, by 7+11+9+16), 18 (risk-engine, by 11), 19 (options-convexity, by 15+18), 20 (macro, by 18), 21-26 (check DECOMPOSITION.md).
### KEY FIX SUMMARY
- **watchlistRepository.ts**: Changed from double-encoding to single JSON.stringify with `{symbol, notes?}` objects. Added `readDefaultWatchlistRaw` helper. Notes preserved on multi-add. 13/13 tests pass.
- **institutionFlowEngine.ts**: H1 (removed 'C' from INCREASE_CODES), M1 (classifyTransactionDirection returns null for zero-share ambiguous), M2 (includeUnchanged option, default=false).
- **OptionsAdapter.ts + CacheRepository.ts**: chain + expiry_dates kind handlers registered, kv_cache table, TTL comment fixed, chain() requires mandatory expiry.
- **All 175 tests pass.** (TypeScript errors: EdgarAdapter.test.ts fetch type mismatch only — pre-existing.)
## COMPLETED slices
1 tracer, 2 auth/2FA/OAuth, 3 onboarding, 4 yfinance-backfill, 5 chart-lab M2, 6 SEC-EDGAR adapter (filings_index/company_facts/filer_cik_meta/full_text_search/13f_holdings/form4_tx + 16 tests), 7a InstitutionFlowEngine (in review), 15a OptionsAdapter (in review), 16 X-cookie+Reddit adapters ✅. Repos: watchlistRepository, portfolioRepository. 145+ backend tests, 2 SPA lint.
1 tracer, 2 auth/2FA/OAuth, 3 onboarding, 4 yfinance-backfill, 5 chart-lab M2, 6 SEC-EDGAR adapter, 16 X-cookie+Reddit adapters. fix-edgar-tests, chart-lab-panel-m2, fix-chartlab-findings, fix-spa-review-findings, fix-backend-review-findings.
## Repo/conventions
- /Users/laptran/Documents/investor-flow. Backend app/server/ (Node 26, node:sqlite, native TS, @trpc/server, yahoo-finance2, zod; test: `cd app/server && node --test --experimental-strip-types "src/**/*.test.ts"`). Frontend app/src/ (Next, Recharts, Tailwind; lint: `cd app && node --test --experimental-strip-types src/__tests__/primary-rule-lint.test.ts`).
@@ -58,10 +66,7 @@ Check: `kill -0 <pid>`.
- DESIGN.md + DECOMPOSITION.md (26 slices) at .automaton/tasks/complete/investor-flow-platform-design/.
## Framework issues filed (for ~/.automaton maintainer)
- ~/.automaton/tasks/orchestrator-session-framework-issues/ (8 issues incl. agent self-complete bypass #7, automaton_create_task broken #1, commit-guard staleness #3, code_review→complete bug_find gate #4).
- ~/.automaton/tasks/orchestrator-session-framework-issues/ (8 issues incl. agent self-complete bypass #7, automaton_create_task broken #1, commit-guard staleness #3, code_review→complete bug_find gate #4, `--can-edit` PosixPath JSON serialization crash #9).
- ~/.automaton/tasks/add-orchestrator-polling-cadence/ (enforceable 5-min cadence + slow-vs-stuck heuristic).
- .automaton/ISSUES_LOG.md (older P0-P3 framework issues from pilot start).
- STALE ISSUES_LOG entries to IGNORE: "full_text_search ETag" + "tests still 1 failing" are RESOLVED (ETag fix landed, 16/16 green).
## Active task board (the ones being worked; many `new` legacy tasks also exist)
slice-10-watchlist-shell|implement|ornith-35 ; slice-15-options-adapter|code_review|qwopus35b ; slice-7-institution-flow|implement|none(needs fix) ; portfolio-repository|code_review|none ; fix-edgar-tests|implement|none(stale, Edgar tests now green — can mark complete/drop). Complete: slice-6, slice-16, chart-lab-panel-m2, fix-chartlab-findings, fix-spa-review-findings, fix-backend-review-findings.