Files
gitea a16050c80a
CI / lint-and-build (push) Has been cancelled
CI / python-checks (3.12) (push) Has been cancelled
feat: multiple updates - alerts, auth, sectors, rotation service, financials ingestion, task specs, and agent framework
2026-06-06 22:01:40 -04:00

1.1 KiB

Task: Alert refactor verification

Goal

Run the full test suite and verify the alert refactor is complete and correct.

Requirements

  1. Run pytest tests/test_alerts.py --tb=short -v — all tests must pass
  2. Run pytest tests/ --tb=short -v — no regressions in other test files
  3. Verify routers/alerts.py is clean:
    • No direct DB calls
    • Uses AlertService for all data access
    • Under 100 lines
  4. Verify services/alert_service.py is clean:
    • All methods are async
    • Uses parameterized queries
    • Under 200 lines
  5. Verify the check_all_alerts endpoint still works (calls check_sentiment_alerts via background task)

Acceptance Criteria

  1. All alert tests pass (23 tests)
  2. No regressions in other test files
  3. Router file is clean and under 100 lines
  4. Service file is clean and under 200 lines

Files to Read

  • src/backend/routers/alerts.py
  • src/backend/services/alert_service.py
  • src/backend/tests/test_alerts.py

Notes

This is a verification-only task. No new code should be written unless a test fails, in which case fix the root cause and re-run.