Files

T

CI / build (push) Has been cancelled

Details

Fix 10 audit bugs: path prefix matching, verdict parsing, CORS, stale-task detection, phase mapping

Batch 1 (High severity):
- Bug 1: --audit cat3 now checks .automaton/tasks/ paths
- Bug 4: Verdict PASS/FAIL uses structured ## Status: line parsing
- Bug 5: register-guards.sh checks .json/.jsonc, writes plugin key, strips comments
- Bug 7: --can-edit/--scope-check path prefix uses os.sep boundary

Batch 2 (Medium/Low severity):
- Bug 2: migrate-project.sh find command parentheses for -prune binding
- Bug 3: vram_detect model prefix matching with known-suffix whitelist
- Bug 6: dashboard reads .state file before artifact heuristic fallback
- Bug 8: removed wildcard CORS, added security headers (nosniff, DENY)
- Bug 9: stale-task detection uses .state.lastedit instead of .state mtime
- Bug 10: TEST_PLAN.md maps to test_design (was implement)

249 tests pass (up from 235). All 10 tasks driven through full workflow to completion.

2026-06-22 10:40:58 -04:00

1014 B

Raw Blame History

Code Review: fix-vram-model-prefix-match

Reviewed Files

scripts/vram_detect.py (_lookup_model_context(), _KNOWN_MODEL_SUFFIXES)

Changes

Replaced raw startswith() with three-tier matching: exact match, : separator (Ollama tags), and - separator with known instruction-tuning suffix whitelist.

Analysis

Correctness: The three-tier approach correctly handles all test cases:
- deepseek-r1:7b matches via : separator ✓
- llama-3.1-8b-instruct matches via - + instruct suffix ✓
- phi-4-mini-instruct rejected (mini not in suffixes) ✓
- gpt-4o-foo-unknown rejected (foo not in suffixes) ✓
- phi-40 rejected (no separator) ✓
Edge cases: gpt-4-turbo is in the dict directly, so it matches via exact match (checked before gpt-4 due to length-descending sort)
Maintainability: The suffix whitelist is explicit and easy to extend

Verdict: PASS

The fix is well-structured, handles all edge cases correctly, and is properly tested.

1014 B Raw Blame History