Files
automaton/tasks/fix-dashboard-read-state/CODE_REVIEW.md
T
Lap Tran 81ccf548e5
CI / build (push) Has been cancelled
Fix 10 audit bugs: path prefix matching, verdict parsing, CORS, stale-task detection, phase mapping
Batch 1 (High severity):
- Bug 1: --audit cat3 now checks .automaton/tasks/ paths
- Bug 4: Verdict PASS/FAIL uses structured ## Status: line parsing
- Bug 5: register-guards.sh checks .json/.jsonc, writes plugin key, strips comments
- Bug 7: --can-edit/--scope-check path prefix uses os.sep boundary

Batch 2 (Medium/Low severity):
- Bug 2: migrate-project.sh find command parentheses for -prune binding
- Bug 3: vram_detect model prefix matching with known-suffix whitelist
- Bug 6: dashboard reads .state file before artifact heuristic fallback
- Bug 8: removed wildcard CORS, added security headers (nosniff, DENY)
- Bug 9: stale-task detection uses .state.lastedit instead of .state mtime
- Bug 10: TEST_PLAN.md maps to test_design (was implement)

249 tests pass (up from 235). All 10 tasks driven through full workflow to completion.
2026-06-22 10:40:58 -04:00

968 B

Code Review: fix-dashboard-read-state

Reviewed Files

  • automaton/dashboard/core/task.py (_state_string_to_task_state(), determine_task_state())

Changes

Added _state_string_to_task_state() helper and modified determine_task_state() to read .state file before falling back to artifact heuristic.

Analysis

  • Correctness: .state file is the source of truth per v2.0 framework design, so it should take precedence
  • Sub-state handling: _state_string_to_task_state() correctly splits on : to extract base phase (e.g. code_review:awaiting_approval → CODE_REVIEW)
  • Fallback: Tasks without .state files still work via artifact heuristic (backward compatible)
  • Null safety: Returns None for unrecognized phase strings, which determine_task_state() handles by falling through to artifacts

Verdict: PASS

The fix correctly prioritizes the .state file as source of truth while maintaining backward compatibility.