Lap Tran
4a2301b077
CI / build (push) Has been cancelled
- Archive 79 completed framework-dev tasks from tasks/ -> tasks/complete/ - status.py: add --cleanup-done and --install-cleanup-schedule commands - Add scripts/automaton-cleanup.sh for periodic task archiving - Dashboard: rename 'Background' tab -> 'Agent', 'Cleanup' agent -> 'Completed Task Archiver', remove redundant group headers and pill badges, dim inactive agent placeholders - .rules.md: add Self-Documenting UI Names rule - New tests: test_cleanup_done.py, expanded test_app.py and test_task.py
1.5 KiB
1.5 KiB
Bug Report: Status Script
Methodology
Reviewed the 980-line status.py implementation and 25 passing tests. Verified all commands, state transitions, validation logic, and error handling.
Acceptance Criteria
| # | Criterion | Result |
|---|---|---|
| 1 | --task shows current phase, allowed/forbidden actions |
✅ |
| 2 | --transition validates and writes .state |
✅ |
| 3 | --transition refuses past :awaiting_approval |
✅ |
| 4 | --approve transitions awaiting → approved |
✅ |
| 5 | --approve refuses if not awaiting approval |
✅ |
| 6 | --create-task creates folder with .state = new |
✅ |
| 7 | --list shows all tasks with phase and approval status |
✅ |
| 8 | --validate-folder checks out-of-order artifacts |
✅ |
| 9 | --audit runs all check categories |
⚠️ See finding 1 |
| 10 | --claim/--release/--next-available/--available |
✅ |
| 11 | --can-edit/--scope-check/--same-session |
✅ |
| 12 | Atomic writes (tmp+rename) | ✅ |
| 13 | .state.approvals log maintained |
✅ |
| 14 | 25 tests passing | ✅ |
Findings
- Minor:
--auditCategory 3 (git modification check) is stubbed — it checks whether the project is a git repo and reports "Skipped: not a git repository" or falls back to a simplified check. Full git-log-based timestamp comparison is not implemented. This is documented as part of the spec's "graceful skip" clause but the implementation is simpler than the spec describes.