Files
automaton/tasks/complete/fix-migrate-find-precedence/CODE_REVIEW.md
T
Lap Tran 4a2301b077
CI / build (push) Has been cancelled
Archive completed tasks, add cleanup commands, self-documenting dashboard UI
- Archive 79 completed framework-dev tasks from tasks/ -> tasks/complete/
- status.py: add --cleanup-done and --install-cleanup-schedule commands
- Add scripts/automaton-cleanup.sh for periodic task archiving
- Dashboard: rename 'Background' tab -> 'Agent', 'Cleanup' agent -> 'Completed Task Archiver', remove redundant group headers and pill badges, dim inactive agent placeholders
- .rules.md: add Self-Documenting UI Names rule
- New tests: test_cleanup_done.py, expanded test_app.py and test_task.py
2026-06-24 22:43:33 -04:00

589 B

Code Review: fix-migrate-find-precedence

Reviewed Files

  • scripts/migrate-project.sh (line 108)

Changes

Added parentheses around -name tests in find command to ensure -prune binds to the entire OR-group.

Verdict: PASS

The fix is correct and minimal. In POSIX find, -a (AND) has higher precedence than -o (OR), so without parentheses, -prune only applies to the last -name test. The parentheses ensure -prune applies to all three directories (.git, node_modules, .automaton).

Verified with bash -n scripts/migrate-project.sh — syntax is valid.