Lap Tran
4a2301b077
CI / build (push) Has been cancelled
- Archive 79 completed framework-dev tasks from tasks/ -> tasks/complete/ - status.py: add --cleanup-done and --install-cleanup-schedule commands - Add scripts/automaton-cleanup.sh for periodic task archiving - Dashboard: rename 'Background' tab -> 'Agent', 'Cleanup' agent -> 'Completed Task Archiver', remove redundant group headers and pill badges, dim inactive agent placeholders - .rules.md: add Self-Documenting UI Names rule - New tests: test_cleanup_done.py, expanded test_app.py and test_task.py
892 B
892 B
Code Review: fix-can-edit-path-prefix
Summary
Fixes path prefix matching at 5 locations to prevent sibling-directory bypass.
Findings
- Correctness:
str(file_path).startswith(proj_str + os.sep) or str(file_path) == proj_strcorrectly handles both files inside the directory and the directory itself. Theos.sepensures the boundary is a path separator, preventing/home/user/project-evilfrom matching/home/user/project. - Consistency: All 5 locations use the same pattern — good.
- Edge cases:
- A file exactly at
proj_str(the project root itself) is handled by the== proj_strclause. - Symlinks:
Path.resolve()is called onfile_path, so symlinks are resolved before comparison. This is correct.
- A file exactly at
- Tests: 3 tests cover the sibling-rejection, subdirectory-acceptance, and can-edit-task scenarios.
Verdict
APPROVED — no issues found.