CI / build (push) Has been cancelled
- Archive 79 completed framework-dev tasks from tasks/ -> tasks/complete/ - status.py: add --cleanup-done and --install-cleanup-schedule commands - Add scripts/automaton-cleanup.sh for periodic task archiving - Dashboard: rename 'Background' tab -> 'Agent', 'Cleanup' agent -> 'Completed Task Archiver', remove redundant group headers and pill badges, dim inactive agent placeholders - .rules.md: add Self-Documenting UI Names rule - New tests: test_cleanup_done.py, expanded test_app.py and test_task.py
956 B
956 B
Code Review: fix-verdict-pass-inference
Summary
Replaces fragile substring search with structured-line parsing, matching the dashboard's existing parse_verdict_status() approach.
Findings
- Correctness:
_parse_verdict_status_line()correctly looks for## Status:and- **Status**:headers, extracting the value after the colon. Theafter_colon.upper()comparison handles case variations. - Consistency: The new helper mirrors
automaton/dashboard/core/task.py:parse_verdict_status()— good alignment between enforcement layers. - Fallback: Unparseable verdicts now return
"human_intervention"instead of the old behavior (which would have returnedhuman_interventionfor anything without "PASS"). This is a safe default. - Edge case: A verdict with
## Status: PASSand "FAIL" in body correctly returnscomplete— the structured parse only looks at the status line.
Verdict
APPROVED — no issues found.