Lap Tran
bc7daf8590
- **Restore 82 completed tasks** from tasks/complete/ back to tasks/ top level (all <7 days old per the cleanup policy; premature bulk archive was fixed). - **Dashboard: fix scroll-reset on auto-refresh** — renderBoard rebuilds the board via innerHTML every 2s, destroying each column-body's scrollTop. Now snapshots column-body scrollTop + board.scrollLeft + view.scrollTop before rebuild and restores after (matched by PHASE_GROUPS index). - **Dashboard UI additions** (pre-existing unstaged work): approval section cards, transition buttons, inline artifact editor (textarea for writing missing SPEC/VERDICT/etc from the detail modal). - **Bind ornith as Implement model** — config.md: Model explicit to omlx/Ornith-1.0-35B-4bit-mlx, context window 32768. Interactive autopilot already used ornith via opencode default; now explicit. - **Fix cleanup stub** — automaton-cleanup.sh had a stale --project arg pointing at a pytest temp dir (test isolation leak). Rewired to point at ~/.automaton. - **Fix plist-isolation test** — test asserted host plist doesn't exist, but a real install creates it. Now snapshots mtime before run, asserts unchanged after (only a write during the test counts as bleed). - **New Playwright smoke test** (tests/test_dashboard_ui.py) — 2 tests: board renders tasks, column scroll survives auto-refresh tick. Verified the test fails without the scroll fix (scrollTop resets to 0). Skipped via importorskip when playwright is absent (main CI stays green). - **Clarify SI loop scope in README** — new-project onboarding section documents the framework-scoped self-improvement loop and options (leave/pause/create project loop). - **CHANGELOG** documents all changes including the known model-divergence gap (mde tasks marked complete but per-role model binding was never implemented).
1020 B
1020 B
Code Review: upgrade-pre-commit-autopilot-check
Summary
PASS — single-file bash script change, clean and follows existing patterns.
Spec Compliance
- Autopilot detection from .agent.md — Met
- Non-terminal task scan on commit — Met
- Warning emitted when hanging tasks found — Met
- Does not block commit — Met
- Existing blocking behavior preserved — Met
Design Conformance
- Bash scripting follows existing hook style — Followed
Code Quality Scorecard
| Dimension | Score (1-5) | Notes |
|---|---|---|
| Correctness | 5 | Fine |
| Architecture | 5 | Minimal change, well-scoped |
| Error Handling | 5 | Uses set -euo pipefail, grep falls back to true |
| Testing | 4 | Hook tested manually in CI |
| Performance | 5 | O(1) overhead |
| Security | 5 | No security concerns |
Items Found
(None)
Test Coverage Assessment
- Verified via bash -n (syntax check)
- Manual test: commit with non-terminal tasks triggers warning
Overall Verdict
RECOMMEND_PASS