- **Restore 82 completed tasks** from tasks/complete/ back to tasks/ top level (all <7 days old per the cleanup policy; premature bulk archive was fixed). - **Dashboard: fix scroll-reset on auto-refresh** — renderBoard rebuilds the board via innerHTML every 2s, destroying each column-body's scrollTop. Now snapshots column-body scrollTop + board.scrollLeft + view.scrollTop before rebuild and restores after (matched by PHASE_GROUPS index). - **Dashboard UI additions** (pre-existing unstaged work): approval section cards, transition buttons, inline artifact editor (textarea for writing missing SPEC/VERDICT/etc from the detail modal). - **Bind ornith as Implement model** — config.md: Model explicit to omlx/Ornith-1.0-35B-4bit-mlx, context window 32768. Interactive autopilot already used ornith via opencode default; now explicit. - **Fix cleanup stub** — automaton-cleanup.sh had a stale --project arg pointing at a pytest temp dir (test isolation leak). Rewired to point at ~/.automaton. - **Fix plist-isolation test** — test asserted host plist doesn't exist, but a real install creates it. Now snapshots mtime before run, asserts unchanged after (only a write during the test counts as bleed). - **New Playwright smoke test** (tests/test_dashboard_ui.py) — 2 tests: board renders tasks, column scroll survives auto-refresh tick. Verified the test fails without the scroll fix (scrollTop resets to 0). Skipped via importorskip when playwright is absent (main CI stays green). - **Clarify SI loop scope in README** — new-project onboarding section documents the framework-scoped self-improvement loop and options (leave/pause/create project loop). - **CHANGELOG** documents all changes including the known model-divergence gap (mde tasks marked complete but per-role model binding was never implemented).
2.1 KiB
2.1 KiB
Bug Report: fix-verdict-parsing
Summary
Critical: PASS verdicts that discuss past failures (FAIL/NEEDS_REVIEW) were falsely classified as BLOCKED due to substring-based verdict parsing. State machine had 4 divergences from orchestrator spec.
Bugs Found
Bug 1: False-BLOCKED verdict parsing — CRITICAL
- Severity: Critical
- Location:
automaton/dashboard/core/task.py:159-169 - Description: Substring search for FAIL/NEEDS_REVIEW checked before PASS. A verdict like "## Status: PASS — the previous FAIL finding was resolved" was classified as BLOCKED.
- Reproduction: Create a VERDICT.md with
## Status: PASSthat mentions the word "FAIL" anywhere in the body. - Suggested Fix: Parse structured status lines (
## Status:/**Status**:) first, fall back to substring only for unstructured verdicts. Fixed.
Bug 2: IMPLEMENTATION.md alone shows "Implement" instead of "Bug Find"
- Severity: Medium
- Location:
automaton/dashboard/core/task.py:181 - Description: A task with only IMPLEMENTATION.md (no BUG_REPORT) showed as "Implement" instead of "Bug Find". The orchestrator spec says this should be Bug Find phase.
- Suggested Fix: Align state machine with orchestrator. Fixed.
Bug 3: ADVERSARIAL_BUG_REPORT alone shows "Adversarial Bug Find" instead of "Bug Find"
- Severity: Low
- Location:
automaton/dashboard/core/task.py:179 - Description: Without a BUG_REPORT present, an ADVERSARIAL_BUG_REPORT artifact shouldn't trigger ADV_BUG_FIND per orchestrator spec (which requires BUG_REPORT + SPEC first). Mapped to BUG_FIND for consistency.
- Suggested Fix: Map ADV alone to BUG_FIND. Fixed.
Bug 4: Filesystem task names bypass validation
- Severity: Medium
- Location:
automaton/dashboard/core/task.py:248 - Description: Directory names with special characters (quotes, spaces) are served to JS and interpolated into HTML onclick attributes.
- Suggested Fix: Skip directories with invalid names in
discover_tasks()andparse_sub_tasks(). Fixed.
Score
+10 (all critical and medium bugs fixed)