- **Restore 82 completed tasks** from tasks/complete/ back to tasks/ top level (all <7 days old per the cleanup policy; premature bulk archive was fixed). - **Dashboard: fix scroll-reset on auto-refresh** — renderBoard rebuilds the board via innerHTML every 2s, destroying each column-body's scrollTop. Now snapshots column-body scrollTop + board.scrollLeft + view.scrollTop before rebuild and restores after (matched by PHASE_GROUPS index). - **Dashboard UI additions** (pre-existing unstaged work): approval section cards, transition buttons, inline artifact editor (textarea for writing missing SPEC/VERDICT/etc from the detail modal). - **Bind ornith as Implement model** — config.md: Model explicit to omlx/Ornith-1.0-35B-4bit-mlx, context window 32768. Interactive autopilot already used ornith via opencode default; now explicit. - **Fix cleanup stub** — automaton-cleanup.sh had a stale --project arg pointing at a pytest temp dir (test isolation leak). Rewired to point at ~/.automaton. - **Fix plist-isolation test** — test asserted host plist doesn't exist, but a real install creates it. Now snapshots mtime before run, asserts unchanged after (only a write during the test counts as bleed). - **New Playwright smoke test** (tests/test_dashboard_ui.py) — 2 tests: board renders tasks, column scroll survives auto-refresh tick. Verified the test fails without the scroll fix (scrollTop resets to 0). Skipped via importorskip when playwright is absent (main CI stays green). - **Clarify SI loop scope in README** — new-project onboarding section documents the framework-scoped self-improvement loop and options (leave/pause/create project loop). - **CHANGELOG** documents all changes including the known model-divergence gap (mde tasks marked complete but per-role model binding was never implemented).
1.5 KiB
1.5 KiB
VERDICT: fix-install-update-flow
Task
Fix 5 issues in the install/update flow: hardcoded git URL, .venv cwd bug, Windows venv path, hook copy-vs-symlink inconsistency, and missing --version smoke test.
Deliverables Review
| Requirement | Status | Evidence |
|---|---|---|
| R1: User-supplied git URL (D11) | DONE | install.sh GIT_URL="${1:-}" with usage and irreversibility warning, 4 tests |
R2: Fix .venv cwd bug |
DONE | Venv in $FRAMEWORK_DIR/.venv, requirements.txt from $FRAMEWORK_DIR, 4 tests |
| R3: Windows venv path | DONE | Platform-aware VENV_PY detection, -m pip, 4 tests |
| R4: Hook copy-vs-symlink | DONE | update.sh and upgrade.sh use cp + chmod +x, 6 tests |
R5: --version smoke test |
DONE | status.py --version after install, 1 test |
| R6: Tests | DONE | 15 tests in tests/test_install_update_flow.py, all passing |
| R7: Documentation | DONE | CHANGELOG and README updated |
Quality Assessment
- Test coverage: 15 new tests, all passing. Full suite 424 passed (was 409). No regressions.
- Shell syntax:
bash -npasses for all 3 scripts. - Security: No hardcoded URLs. No shell injection vectors. No path traversal.
- Backward compat: Existing users with symlinked hooks can re-run
install-hooks.shto switch to copies. - Documentation: README and CHANGELOG accurate.
Verdict
APPROVED -- ready for complete.
All 7 requirements fully implemented, tested, and documented. The install/update flow is now portable, secure, and consistent.