Lap Tran
bc7daf8590
- **Restore 82 completed tasks** from tasks/complete/ back to tasks/ top level (all <7 days old per the cleanup policy; premature bulk archive was fixed). - **Dashboard: fix scroll-reset on auto-refresh** — renderBoard rebuilds the board via innerHTML every 2s, destroying each column-body's scrollTop. Now snapshots column-body scrollTop + board.scrollLeft + view.scrollTop before rebuild and restores after (matched by PHASE_GROUPS index). - **Dashboard UI additions** (pre-existing unstaged work): approval section cards, transition buttons, inline artifact editor (textarea for writing missing SPEC/VERDICT/etc from the detail modal). - **Bind ornith as Implement model** — config.md: Model explicit to omlx/Ornith-1.0-35B-4bit-mlx, context window 32768. Interactive autopilot already used ornith via opencode default; now explicit. - **Fix cleanup stub** — automaton-cleanup.sh had a stale --project arg pointing at a pytest temp dir (test isolation leak). Rewired to point at ~/.automaton. - **Fix plist-isolation test** — test asserted host plist doesn't exist, but a real install creates it. Now snapshots mtime before run, asserts unchanged after (only a write during the test counts as bleed). - **New Playwright smoke test** (tests/test_dashboard_ui.py) — 2 tests: board renders tasks, column scroll survives auto-refresh tick. Verified the test fails without the scroll fix (scrollTop resets to 0). Skipped via importorskip when playwright is absent (main CI stays green). - **Clarify SI loop scope in README** — new-project onboarding section documents the framework-scoped self-improvement loop and options (leave/pause/create project loop). - **CHANGELOG** documents all changes including the known model-divergence gap (mde tasks marked complete but per-role model binding was never implemented).
2.3 KiB
IMPLEMENTATION: fix-install-update-flow
Summary
Fixed 5 issues in the install/update flow: hardcoded git URL, .venv cwd bug, Windows venv path, hook copy-vs-symlink inconsistency, and missing --version smoke test.
Changes
R1 -- User-supplied git URL (D11)
scripts/install.sh: Replaced hardcoded http://10.37.0.86:3003/hermes/automaton with GIT_URL="${1:-}". If empty, prints usage with irreversibility warning and exits 1. The if [ -d "$FRAMEWORK_DIR" ] check now exit 0 instead of falling through to else.
R2 -- Fix .venv cwd bug
scripts/install.sh: Moved venv setup to use $FRAMEWORK_DIR/.venv instead of relative .venv. Changed requirements.txt to $FRAMEWORK_DIR/requirements.txt.
R3 -- Windows venv path
scripts/install.sh: Added platform-aware venv Python detection:
$FRAMEWORK_DIR/.venv/bin/python3(Unix)$FRAMEWORK_DIR/.venv/Scripts/python.exe(Windows)- Fallback:
python3
Uses "$VENV_PY" -m pip instead of .venv/bin/pip for cross-platform compatibility.
R4 -- Hook copy-vs-symlink consistency
scripts/update.sh: Changedln -sf "$HOOK_SRC" "$HOOK_DST"tocp "$HOOK_SRC" "$HOOK_DST"+chmod +x "$HOOK_DST".scripts/upgrade.sh: Replaced allln -sfand symlink-checking logic (readlink,-L) withcp+chmod +x. Simplified the hook-exists warning to point toinstall-hooks.sh.
R5 -- --version smoke test
scripts/install.sh: Added python3 "$FRAMEWORK_DIR/scripts/status.py" --version || echo "WARNING: ..." after self-improvement loop bootstrap.
R6 -- Tests
tests/test_install_update_flow.py: 15 tests across 4 classes:
TestInstallShGitUrl(4 tests): git URL required, no hardcoded URL, usage message, irreversibility warningTestInstallShVenv(4 tests): venv in framework dir, Windows path,-m pip, no relative venvTestInstallShVersionCheck(1 test): version check presentTestHookConsistency(6 tests): update.sh uses cp, upgrade.sh uses cp, install-hooks.sh uses cp, chmod present, no symlink check
R7 -- Documentation
CHANGELOG.md: task 8 entryREADME.md: updated install instructions
Verification
bash -n scripts/install.sh scripts/update.sh scripts/upgrade.sh-- OKpython3 -m pytest tests/test_install_update_flow.py -v-- 15 passedpython3 -m pytest tests/ -q-- 424 passed (409 + 15 new)