Lap Tran
bc7daf8590
- **Restore 82 completed tasks** from tasks/complete/ back to tasks/ top level (all <7 days old per the cleanup policy; premature bulk archive was fixed). - **Dashboard: fix scroll-reset on auto-refresh** — renderBoard rebuilds the board via innerHTML every 2s, destroying each column-body's scrollTop. Now snapshots column-body scrollTop + board.scrollLeft + view.scrollTop before rebuild and restores after (matched by PHASE_GROUPS index). - **Dashboard UI additions** (pre-existing unstaged work): approval section cards, transition buttons, inline artifact editor (textarea for writing missing SPEC/VERDICT/etc from the detail modal). - **Bind ornith as Implement model** — config.md: Model explicit to omlx/Ornith-1.0-35B-4bit-mlx, context window 32768. Interactive autopilot already used ornith via opencode default; now explicit. - **Fix cleanup stub** — automaton-cleanup.sh had a stale --project arg pointing at a pytest temp dir (test isolation leak). Rewired to point at ~/.automaton. - **Fix plist-isolation test** — test asserted host plist doesn't exist, but a real install creates it. Now snapshots mtime before run, asserts unchanged after (only a write during the test counts as bleed). - **New Playwright smoke test** (tests/test_dashboard_ui.py) — 2 tests: board renders tasks, column scroll survives auto-refresh tick. Verified the test fails without the scroll fix (scrollTop resets to 0). Skipped via importorskip when playwright is absent (main CI stays green). - **Clarify SI loop scope in README** — new-project onboarding section documents the framework-scoped self-improvement loop and options (leave/pause/create project loop). - **CHANGELOG** documents all changes including the known model-divergence gap (mde tasks marked complete but per-role model binding was never implemented).
2.1 KiB
CODE_REVIEW: fix-install-update-flow
Reviewed Files
scripts/install.sh-- complete restructure (git URL arg, venv fix, version check)scripts/update.sh-- hook copy fixscripts/upgrade.sh-- hook copy fix, symlink logic removedtests/test_install_update_flow.py-- 15 testsREADME.md-- updated install instructionsCHANGELOG.md-- task 8 entry
Findings
1. install.sh restructure
The original if [ -d "$FRAMEWORK_DIR" ]; then ... else ... fi structure was restructured to early-exit (exit 0) for the already-installed case, then top-level code for the install case. This is cleaner and avoids the orphaned fi bug that was present in the original (the venv setup was outside the if/else/fi).
The git URL is now GIT_URL="${1:-}" with a clear usage message and irreversibility warning. The hardcoded private IP URL is gone.
Verdict: PASS
2. Venv fix
The venv is now created in $FRAMEWORK_DIR/.venv instead of CWD. The requirements.txt path is $FRAMEWORK_DIR/requirements.txt. Platform-aware Python detection handles both Unix (.venv/bin/python3) and Windows (.venv/Scripts/python.exe). Uses "$VENV_PY" -m pip for cross-platform pip.
Verdict: PASS
3. Hook consistency
All three scripts (install-hooks.sh, update.sh, upgrade.sh) now use cp + chmod +x for hooks. No more ln -sf. The upgrade.sh symlink-checking logic (readlink, -L) is removed, simplifying the code.
Verdict: PASS
4. Version check
status.py --version is called after all setup. The || echo "WARNING: ..." ensures the script continues even if the version check fails.
Verdict: PASS
5. Test coverage
15 tests cover all 5 requirements. Tests check script content (not execution) for the required patterns, which is appropriate for shell script testing in CI.
Verdict: PASS
6. Shell syntax
bash -n passes for all three scripts.
Verdict: PASS
Summary
All 6 review areas pass. The implementation fixes all 5 issues cleanly. 15 new tests. Full suite: 424 passed.
Overall verdict: APPROVED