Lap Tran
bc7daf8590
- **Restore 82 completed tasks** from tasks/complete/ back to tasks/ top level (all <7 days old per the cleanup policy; premature bulk archive was fixed). - **Dashboard: fix scroll-reset on auto-refresh** — renderBoard rebuilds the board via innerHTML every 2s, destroying each column-body's scrollTop. Now snapshots column-body scrollTop + board.scrollLeft + view.scrollTop before rebuild and restores after (matched by PHASE_GROUPS index). - **Dashboard UI additions** (pre-existing unstaged work): approval section cards, transition buttons, inline artifact editor (textarea for writing missing SPEC/VERDICT/etc from the detail modal). - **Bind ornith as Implement model** — config.md: Model explicit to omlx/Ornith-1.0-35B-4bit-mlx, context window 32768. Interactive autopilot already used ornith via opencode default; now explicit. - **Fix cleanup stub** — automaton-cleanup.sh had a stale --project arg pointing at a pytest temp dir (test isolation leak). Rewired to point at ~/.automaton. - **Fix plist-isolation test** — test asserted host plist doesn't exist, but a real install creates it. Now snapshots mtime before run, asserts unchanged after (only a write during the test counts as bleed). - **New Playwright smoke test** (tests/test_dashboard_ui.py) — 2 tests: board renders tasks, column scroll survives auto-refresh tick. Verified the test fails without the scroll fix (scrollTop resets to 0). Skipped via importorskip when playwright is absent (main CI stays green). - **Clarify SI loop scope in README** — new-project onboarding section documents the framework-scoped self-improvement loop and options (leave/pause/create project loop). - **CHANGELOG** documents all changes including the known model-divergence gap (mde tasks marked complete but per-role model binding was never implemented).
2.2 KiB
Bug Report: fix-harness-command-template
Self-bug-hunt against the implementation. No adversarial pass yet (separate phase).
Bugs found
None blocking. The fix is small (a few lines in _invoke_harness plus test scaffolding updates). Observations below are non-blocking.
Observations (non-blocking)
O1 — _resolve_prompt return value can be an empty string
If prompt_ref is None or "", _resolve_prompt returns "" (line return prompt_ref or ""). Then Path(resolved_prompt).read_text() raises OSError and prompt_content becomes "". The default command becomes ["opencode", "run", "--dir", "{cwd}", ""] — a single empty-string positional. Harmless (opencode treats empty message as no prompt); behavior matches v1's "--prompt-file", "" which was also empty.
O2 — Tested harness commands don't exercise --cwd absent case for cross-platform
Tests assume --dir works on this machine (darwin). On Windows, opencode run --dir <path> should work the same way, but no Windows CI run is exercised here. Out of scope — the path-separator handling is opencode's job, not the runner's.
O3 — Path(resolved_prompt).read_text() uses default encoding
No encoding="utf-8" argument. On Windows the default encoding is cp1252; a prompt file with non-ASCII content could mis-decode. Low-impact; the rest of the framework already uses default encoding in similar reads (e.g. _state, _read_state_loop). Documented as a follow-up if it ever bites.
O4 — Test stub content uses a trailing newline
_make_loop writes f"prompt: {prompt_ref}\n" — the trailing \n is preserved in {prompt_content}. Tests assert with .rstrip() to handle it. In real usage, prompt files routinely end with a newline and the harness treats it as whitespace. Not a bug; just a note for future test maintainability.
O5 — No smoke test against real opencode run
The SPEC noted an optional @pytest.mark.skipif(not shutil.which("opencode")) smoke test asserting --dir exists in opencode run --help. Not added in this task to keep the change focused. The 7 new unit tests cover the construction of the default command directly, which is the primary surface.
Verdict
PASS — proceed to adversarial_bug_find.