- **Restore 82 completed tasks** from tasks/complete/ back to tasks/ top level (all <7 days old per the cleanup policy; premature bulk archive was fixed). - **Dashboard: fix scroll-reset on auto-refresh** — renderBoard rebuilds the board via innerHTML every 2s, destroying each column-body's scrollTop. Now snapshots column-body scrollTop + board.scrollLeft + view.scrollTop before rebuild and restores after (matched by PHASE_GROUPS index). - **Dashboard UI additions** (pre-existing unstaged work): approval section cards, transition buttons, inline artifact editor (textarea for writing missing SPEC/VERDICT/etc from the detail modal). - **Bind ornith as Implement model** — config.md: Model explicit to omlx/Ornith-1.0-35B-4bit-mlx, context window 32768. Interactive autopilot already used ornith via opencode default; now explicit. - **Fix cleanup stub** — automaton-cleanup.sh had a stale --project arg pointing at a pytest temp dir (test isolation leak). Rewired to point at ~/.automaton. - **Fix plist-isolation test** — test asserted host plist doesn't exist, but a real install creates it. Now snapshots mtime before run, asserts unchanged after (only a write during the test counts as bleed). - **New Playwright smoke test** (tests/test_dashboard_ui.py) — 2 tests: board renders tasks, column scroll survives auto-refresh tick. Verified the test fails without the scroll fix (scrollTop resets to 0). Skipped via importorskip when playwright is absent (main CI stays green). - **Clarify SI loop scope in README** — new-project onboarding section documents the framework-scoped self-improvement loop and options (leave/pause/create project loop). - **CHANGELOG** documents all changes including the known model-divergence gap (mde tasks marked complete but per-role model binding was never implemented).
1.1 KiB
1.1 KiB
Code Review: fix-dashboard-cors-origin
Reviewed Files
automaton/dashboard/ui/app.py(SECURITY_HEADERS,_send_json(),_send_error(),do_OPTIONS())tests/test_app.py
Changes
Removed wildcard CORS headers (Access-Control-Allow-Origin: *), replaced with security headers (X-Content-Type-Options: nosniff, X-Frame-Options: DENY).
Analysis
- Security: Removing wildcard CORS eliminates the risk of cross-origin attacks from malicious local web pages
- Single-origin app: The dashboard is a local web app served from a single origin — CORS is unnecessary
- Security headers:
X-Content-Type-Options: nosniffprevents MIME type sniffing,X-Frame-Options: DENYprevents clickjacking - OPTIONS handler:
do_OPTIONS()still returns 204 No Content (for preflight requests) but without CORS headers - Tests: Test assertions correctly verify absence of CORS headers and presence of security headers
Verdict: PASS
The fix eliminates a security vulnerability while adding useful hardening headers. Tests are properly updated.