Lap Tran
bc7daf8590
- **Restore 82 completed tasks** from tasks/complete/ back to tasks/ top level (all <7 days old per the cleanup policy; premature bulk archive was fixed). - **Dashboard: fix scroll-reset on auto-refresh** — renderBoard rebuilds the board via innerHTML every 2s, destroying each column-body's scrollTop. Now snapshots column-body scrollTop + board.scrollLeft + view.scrollTop before rebuild and restores after (matched by PHASE_GROUPS index). - **Dashboard UI additions** (pre-existing unstaged work): approval section cards, transition buttons, inline artifact editor (textarea for writing missing SPEC/VERDICT/etc from the detail modal). - **Bind ornith as Implement model** — config.md: Model explicit to omlx/Ornith-1.0-35B-4bit-mlx, context window 32768. Interactive autopilot already used ornith via opencode default; now explicit. - **Fix cleanup stub** — automaton-cleanup.sh had a stale --project arg pointing at a pytest temp dir (test isolation leak). Rewired to point at ~/.automaton. - **Fix plist-isolation test** — test asserted host plist doesn't exist, but a real install creates it. Now snapshots mtime before run, asserts unchanged after (only a write during the test counts as bleed). - **New Playwright smoke test** (tests/test_dashboard_ui.py) — 2 tests: board renders tasks, column scroll survives auto-refresh tick. Verified the test fails without the scroll fix (scrollTop resets to 0). Skipped via importorskip when playwright is absent (main CI stays green). - **Clarify SI loop scope in README** — new-project onboarding section documents the framework-scoped self-improvement loop and options (leave/pause/create project loop). - **CHANGELOG** documents all changes including the known model-divergence gap (mde tasks marked complete but per-role model binding was never implemented).
1.1 KiB
1.1 KiB
Adversarial Bug Report: fix-can-edit-path-prefix
Summary
Adversarial review of the path prefix fix. No additional bugs found.
Bugs Found
No bugs found.
Analysis
- Security — symlink bypass:
Path(args.file).resolve()resolves symlinks before comparison, so a symlink inside the project pointing outside would be resolved to the real path and correctly rejected. Good. - Trailing slash: The
== proj_strclause handles the edge case wherefile_pathis exactly the project directory.Path.resolve()strips trailing slashes, so this is robust. - Case sensitivity: On macOS (default filesystem is case-insensitive),
Path.resolve()does not normalize case. A file at/Users/user/Project/file.pywould not match project/Users/user/project. This is consistent with the original behavior and not a regression. - Framework vs project: The fix applies
os.septo bothproj_strandauto_strchecks — consistent across all 5 locations. - Empty file path:
args.fileis required by argparse for--can-edit --fileand--scope-check, so empty paths are not reachable.
Score
0
ADVERSARIAL_BUG_FIND_COMPLETE