Lap Tran
bc7daf8590
- **Restore 82 completed tasks** from tasks/complete/ back to tasks/ top level (all <7 days old per the cleanup policy; premature bulk archive was fixed). - **Dashboard: fix scroll-reset on auto-refresh** — renderBoard rebuilds the board via innerHTML every 2s, destroying each column-body's scrollTop. Now snapshots column-body scrollTop + board.scrollLeft + view.scrollTop before rebuild and restores after (matched by PHASE_GROUPS index). - **Dashboard UI additions** (pre-existing unstaged work): approval section cards, transition buttons, inline artifact editor (textarea for writing missing SPEC/VERDICT/etc from the detail modal). - **Bind ornith as Implement model** — config.md: Model explicit to omlx/Ornith-1.0-35B-4bit-mlx, context window 32768. Interactive autopilot already used ornith via opencode default; now explicit. - **Fix cleanup stub** — automaton-cleanup.sh had a stale --project arg pointing at a pytest temp dir (test isolation leak). Rewired to point at ~/.automaton. - **Fix plist-isolation test** — test asserted host plist doesn't exist, but a real install creates it. Now snapshots mtime before run, asserts unchanged after (only a write during the test counts as bleed). - **New Playwright smoke test** (tests/test_dashboard_ui.py) — 2 tests: board renders tasks, column scroll survives auto-refresh tick. Verified the test fails without the scroll fix (scrollTop resets to 0). Skipped via importorskip when playwright is absent (main CI stays green). - **Clarify SI loop scope in README** — new-project onboarding section documents the framework-scoped self-improvement loop and options (leave/pause/create project loop). - **CHANGELOG** documents all changes including the known model-divergence gap (mde tasks marked complete but per-role model binding was never implemented).
1.8 KiB
1.8 KiB
Implementation: Dashboard Task Review and Approval
Summary
Added a complete review/approval workflow to the dashboard. Tasks can be reviewed, approved, or flagged for changes directly from the UI.
Changes Made
Backend (app.py)
_get_review_status()— reads REVIEW.md from task folder, parses status/timestamp/comment_write_review()— writes REVIEW.md with approval status and optional comment_handle_review()— POST endpoint for review submission_serve_review_summary()— aggregate review metrics across all tasks- Integrated review data into task API responses
- Added unquote() for URL-encoded task names
Frontend (dashboard.js)
- Review status badge on each task card (🟡 pending, ✅ approved, ❌ changes requested)
- Review section in detail panel: status display, comment textarea, Approve/Request Changes buttons
submitReview()— posts review to API, closes modal on success- Review filter dropdown — filter board by review status
- Pending review count in header stats
getTaskDisplayGroup()— approved planning tasks move to Design column, rejected to Blocked
Styles (styles.css)
.review-badge— status indicator styling (approved/requested/pending colors).review-textarea— comment input styling.review-actions— button layout.review-comment— previous comment display.review-btn— approve/changes button styles
HTML (index.html)
- Review filter dropdown in filter bar
- Pending review count display in header
Files Modified
automaton/dashboard/ui/app.py— review API endpointsautomaton/dashboard/html/dashboard.js— review UI, display groupingautomaton/dashboard/html/styles.css— review component stylesautomaton/dashboard/html/index.html— review filter and stats