Lap Tran
bc7daf8590
- **Restore 82 completed tasks** from tasks/complete/ back to tasks/ top level (all <7 days old per the cleanup policy; premature bulk archive was fixed). - **Dashboard: fix scroll-reset on auto-refresh** — renderBoard rebuilds the board via innerHTML every 2s, destroying each column-body's scrollTop. Now snapshots column-body scrollTop + board.scrollLeft + view.scrollTop before rebuild and restores after (matched by PHASE_GROUPS index). - **Dashboard UI additions** (pre-existing unstaged work): approval section cards, transition buttons, inline artifact editor (textarea for writing missing SPEC/VERDICT/etc from the detail modal). - **Bind ornith as Implement model** — config.md: Model explicit to omlx/Ornith-1.0-35B-4bit-mlx, context window 32768. Interactive autopilot already used ornith via opencode default; now explicit. - **Fix cleanup stub** — automaton-cleanup.sh had a stale --project arg pointing at a pytest temp dir (test isolation leak). Rewired to point at ~/.automaton. - **Fix plist-isolation test** — test asserted host plist doesn't exist, but a real install creates it. Now snapshots mtime before run, asserts unchanged after (only a write during the test counts as bleed). - **New Playwright smoke test** (tests/test_dashboard_ui.py) — 2 tests: board renders tasks, column scroll survives auto-refresh tick. Verified the test fails without the scroll fix (scrollTop resets to 0). Skipped via importorskip when playwright is absent (main CI stays green). - **Clarify SI loop scope in README** — new-project onboarding section documents the framework-scoped self-improvement loop and options (leave/pause/create project loop). - **CHANGELOG** documents all changes including the known model-divergence gap (mde tasks marked complete but per-role model binding was never implemented).
2.6 KiB
CODE_REVIEW: add-self-improvement-loop
Reviewed Files
scripts/install.sh-- self-improvement loop bootstrap (lines ~70-82)scripts/update.sh-- idempotent loop bootstrap (lines ~61-70)tests/test_self_improvement_loop.py-- 16 testsCHANGELOG.md-- task 7 entrydesign/loops/technical.mdsection 9 -- updated install noteREADME.md-- self-improvement loop default-on section
Findings
1. install.sh -- loop bootstrap placement
The loop bootstrap is placed inside the else block (after the git clone), after guard registration and before fi. This is correct -- the loop should only be created on fresh installs, not when the framework is already installed (the if [ -d "$FRAMEWORK_DIR" ] branch prints "already installed" and exits).
The || true ensures install continues even if status.py fails (e.g. Python not in PATH yet, or schedule installation fails on an unusual platform). The framework works without the loop.
Verdict: PASS
2. update.sh -- idempotent bootstrap
The if [ ! -d "$FRAMEWORK_DIR/loops/self-improvement" ] check correctly prevents duplicate creation. --create-loop itself also refuses duplicates (returns rc=2), but the directory check avoids the error output entirely. The || true on both commands ensures update continues on failure.
Verdict: PASS
3. Test coverage
TestInstallShWiring(5 tests): covers create-loop, install-schedule, opt-out message, framework project, and non-fatal behavior. All assertions check the script content.TestUpdateShWiring(4 tests): covers create-loop, idempotent check, install-schedule, and non-fatal behavior.TestSelfImprovementTemplate(5 tests): regression guard for template fields.TestCreateLoopFromTemplate(2 tests): integration test forcmd_create_loopwith the self-improvement template.
Verdict: PASS
4. Shell syntax
bash -n scripts/install.sh scripts/update.sh passes. No syntax errors.
Verdict: PASS
5. Edge cases
- Python not in PATH:
|| truehandles this. Install continues. - Loop already exists (update.sh): directory check prevents creation;
--create-loopalso refuses. - Schedule installation fails:
|| truehandles this. Loop is created but not scheduled; user can manually--install-schedulelater. - Framework not in ~/.automaton: the
$FRAMEWORK_DIRvariable is set at the top of each script and used consistently.
Verdict: PASS
Summary
All 5 review areas pass. The implementation is clean, idempotent, and well-tested. 16 new tests cover script wiring, template validation, and loop creation. Full suite: 409 passed.
Overall verdict: APPROVED