Lap Tran
bc7daf8590
- **Restore 82 completed tasks** from tasks/complete/ back to tasks/ top level (all <7 days old per the cleanup policy; premature bulk archive was fixed). - **Dashboard: fix scroll-reset on auto-refresh** — renderBoard rebuilds the board via innerHTML every 2s, destroying each column-body's scrollTop. Now snapshots column-body scrollTop + board.scrollLeft + view.scrollTop before rebuild and restores after (matched by PHASE_GROUPS index). - **Dashboard UI additions** (pre-existing unstaged work): approval section cards, transition buttons, inline artifact editor (textarea for writing missing SPEC/VERDICT/etc from the detail modal). - **Bind ornith as Implement model** — config.md: Model explicit to omlx/Ornith-1.0-35B-4bit-mlx, context window 32768. Interactive autopilot already used ornith via opencode default; now explicit. - **Fix cleanup stub** — automaton-cleanup.sh had a stale --project arg pointing at a pytest temp dir (test isolation leak). Rewired to point at ~/.automaton. - **Fix plist-isolation test** — test asserted host plist doesn't exist, but a real install creates it. Now snapshots mtime before run, asserts unchanged after (only a write during the test counts as bleed). - **New Playwright smoke test** (tests/test_dashboard_ui.py) — 2 tests: board renders tasks, column scroll survives auto-refresh tick. Verified the test fails without the scroll fix (scrollTop resets to 0). Skipped via importorskip when playwright is absent (main CI stays green). - **Clarify SI loop scope in README** — new-project onboarding section documents the framework-scoped self-improvement loop and options (leave/pause/create project loop). - **CHANGELOG** documents all changes including the known model-divergence gap (mde tasks marked complete but per-role model binding was never implemented).
2.7 KiB
2.7 KiB
CODE_REVIEW: add-blast-radius-scheduler
Reviewed against SPEC.md R1-R8.
R1-R8 checklist
| Req | Status | Notes |
|---|---|---|
| R1 _ensure_worktree | PASS | Dispatches on blast_radius.use_worktree (default True); creates via git worktree add; records in state |
| R2 graceful degradation | PASS | Not-a-repo, git-missing, and worktree-add-fail all return project root with WARNING |
| R3 cmd_tick integration | PASS | Step 4 replaced with cwd = _ensure_worktree(...) |
| R4 branch already exists | PASS | Retries without -b when stderr contains "already exists" |
| R5 state consistency | PASS | Stale path cleared; state written atomically |
| R6 platform paths | PASS | pathlib.Path throughout; git handles OS normalization |
| R7 doc updates | PASS | technical.md section 7 updated; CHANGELOG updated |
| R8 tests | PASS | 15 tests, 6 classes + regression |
Edge cases checked
use_worktreemissing fromblast_radius-- defaults toTrueviablast.get("use_worktree", True). PASSblast_radiusentirely missing --cfg.get("blast_radius") or {}returns empty dict;use_worktreedefaults True. PASS- Worktree path exists but is not a git worktree --
git worktree addwould fail; runner falls back to project root. PASS - Branch exists but worktree was deleted -- first
git worktree add -bfails with "already exists"; retry without-bsucceeds. PASS git worktree addtimes out --_git_runhastimeout=15;subprocess.TimeoutExpiredis aSubprocessError, caught by_git_run. PASS- State written before step 10 -- intentional: the worktree exists on disk, so recording it is correct even if the tick crashes later. The drift gate will check it on the next tick. PASS
- Concurrent ticks both creating worktree -- TOCTOU: both might pass
worktree_path is null, both callgit worktree add, second one fails because the path exists. The second tick falls back to project root. Not ideal but safe (no state corruption; atomic write). Same TOCTOU class asadd-status-brakesA6. PASS for v1.
Code-quality observations
_git_runis a generic wrapper -- could be reused for other git operations in the runner. Currently only used by_ensure_worktree. Fine for v1.- Branch name
loop/<name>-- matches technical.md. If the loop name contains slashes (e.g.ci/triage), the branch name would beloop/ci/triagewhich git treats as a hierarchical branch. But_is_kebab_casein status.py rejects slashes in loop names. PASS. - No worktree removal on loop deletion -- if the user deletes a loop dir, the worktree branch remains in the repo. Worktree GC is deferred to v1.1 (BACKLOG). Accepted.
Verdict
APPROVE. Ready for bug_find.