Files

T

Lap Tran bc7daf8590 Restore archived tasks, fix dashboard scroll-reset, bind ornith, add Playwright smoke test

- **Restore 82 completed tasks** from tasks/complete/ back to tasks/ top
  level (all <7 days old per the cleanup policy; premature bulk archive
  was fixed).
- **Dashboard: fix scroll-reset on auto-refresh** — renderBoard rebuilds
  the board via innerHTML every 2s, destroying each column-body's
  scrollTop. Now snapshots column-body scrollTop + board.scrollLeft +
  view.scrollTop before rebuild and restores after (matched by
  PHASE_GROUPS index).
- **Dashboard UI additions** (pre-existing unstaged work): approval
  section cards, transition buttons, inline artifact editor (textarea for
  writing missing SPEC/VERDICT/etc from the detail modal).
- **Bind ornith as Implement model** — config.md: Model explicit to
  omlx/Ornith-1.0-35B-4bit-mlx, context window 32768. Interactive
  autopilot already used ornith via opencode default; now explicit.
- **Fix cleanup stub** — automaton-cleanup.sh had a stale --project arg
  pointing at a pytest temp dir (test isolation leak). Rewired to point
  at ~/.automaton.
- **Fix plist-isolation test** — test asserted host plist doesn't exist,
  but a real install creates it. Now snapshots mtime before run, asserts
  unchanged after (only a write during the test counts as bleed).
- **New Playwright smoke test** (tests/test_dashboard_ui.py) — 2 tests:
  board renders tasks, column scroll survives auto-refresh tick.
  Verified the test fails without the scroll fix (scrollTop resets to 0).
  Skipped via importorskip when playwright is absent (main CI stays
  green).
- **Clarify SI loop scope in README** — new-project onboarding section
  documents the framework-scoped self-improvement loop and options
  (leave/pause/create project loop).
- **CHANGELOG** documents all changes including the known model-divergence
  gap (mde tasks marked complete but per-role model binding was never
  implemented).

2026-06-26 10:05:18 -04:00

1.8 KiB

Raw Permalink Blame History

BUG_REPORT: add-blast-radius-scheduler

Probed worktree creation, fallback, and state consistency against edge cases.

Bugs found

None blocking. Informational observations below.

Observations (non-blocking)

O1 -- Worktree state written before step 10 (idempotence gap)

_ensure_worktree calls _write_state_loop to record worktree_path/worktree_branch immediately after worktree creation. If the tick crashes between this point and step 10 (state advance), iteration_count is NOT incremented (correct), but worktree_path IS set in .state.loop. On the next tick, the runner reuses the existing worktree (which exists on disk). This is correct behavior -- the worktree was created, it exists, reusing it is right. The "idempotent in failure" contract from task 3 refers to iteration_count and last_verdict, not to worktree state. Accepted.

O2 -- `git worktree add` on a repo with uncommitted changes

git worktree add creates a new working tree from the current HEAD. It does not require a clean working tree in the main checkout. So this is fine -- the worktree gets a clean copy of HEAD. No issue.

O3 -- Worktree path collides with existing directory

If <loop_path>/worktree already exists as a non-git directory (e.g. the user manually created it), git worktree add will fail with "already exists". The runner falls back to project root. The user would need to remove the directory manually. Acceptable for v1.

O4 -- No cleanup of worktree on `--approve --loop` or loop deletion

When a loop is halted and then approved (resumed), the worktree remains. When a loop dir is deleted, the worktree branch remains in the repo. Worktree GC is a v1.1 item (BACKLOG worktree-gc). Accepted.

Verdict

PASS -- no blocker bugs. All observations are accepted trade-offs or v1.1 hardening items.

1.8 KiB Raw Permalink Blame History