# Code Review: fix-test-plan-phase-mapping ## Reviewed Files - `scripts/status.py` (line 348-349: `_infer_state_from_artifacts()`) - `automaton/dashboard/core/task.py` (line 548-549: `determine_task_state()`) - `tests/test_task.py` ## Changes Changed `TEST_PLAN.md` mapping from `implement` → `test_design` in both `status.py` and dashboard `task.py`. ## Analysis - **Correctness**: `TEST_PLAN.md` is produced during the `test_design` phase, not `implement`. The workflow is: `test_design` → (approval) → `implement`. TEST_PLAN.md is the output of `test_design`, so it should map to `test_design`. - **Consistency**: Both `status.py` and dashboard `task.py` now use the same mapping - **Test updates**: Existing tests updated to assert `TEST_DESIGN` instead of `IMPLEMENT`, and new test added for `--upgrade` inference - **No regression**: Tasks with both TEST_PLAN.md and IMPLEMENTATION.md still correctly map to `code_review` (because IMPLEMENTATION.md is checked first) ## Verdict: PASS The fix is correct, minimal, and consistent across both enforcement and dashboard code.