Complete tasks 3-7: harden verdict parsing, outputs retention, base branch, linux schedule parity, claim loop task

2026-06-24 10:31:49 -04:00
parent dd2726c0dd
commit e13513faaa
193 changed files with 14934 additions and 98 deletions
@@ -0,0 +1,24 @@
+# Doc Review: fix-harness-command-template
+
+Reviewed docs touched by or referring to the fix.
+
+## Files reviewed
+
+- `CHANGELOG.md` — added a new `### Fixed — harness command template (task fix-harness-command-template)` entry at the top of `[unreleased]` covering the fix, the new `{prompt_content}` token, backwards compat, the inline UnicodeDecodeError fix, harness-agnostic contract preservation, test scaffolding updates, and the 7 new tests. Also corrected the stale `add-loop-runner` v1 entry that mentioned the old `--prompt-file`/`--cwd` default — pointed readers at the v1.1 fix entry instead. Computed full-suite count as 440 (was 433; +7 new).
+- `README.md` — updated the `harness.command` row in the loop.json fields table to mention `{prompt}`, `{prompt_content}`, `{cwd}` tokens and the override pattern for non-opencode harnesses (Pi Dev, aider, etc.).
+- `design/loops/technical.md` §8 — rewritten to document the new default shape; added a per-token explanation table including `{prompt_content}`; added a `--model` override example for routing ticks to a local LLM (Qwen, etc.); added three non-opencode examples (Pi Dev, aider, generic shell wrapper); reaffirmed the D8 / harness-agnostic contract.
+- `design/loops/technical.md` §9 — updated the self-improvement template's `harness.command` to the new default.
+- `templates/loops/self-improvement/loop.json` — `harness.command` updated to the new default.
+- `AGENTS.md` — no edits needed (the AGENTS.md loop runner bullet mentions the binary and the per-tick engine at a high level; doesn't reference the default command shape).
+- `prompts/loop-*.md` — no edits needed (prompts are content; no flag references).
+- `contracts/harness-integration.md` — no edits needed (covers pre-edit guard, not tick harness invocation).
+- `plugins/automaton-guard-pi/` — no edits needed (pre-edit guard plugin; unaffected by tick harness command fix).
+- `scripts/status.py` — no edits needed (status.py does not invoke the harness). `--install-schedule` writes a stub at the loop dir; the stub invokes `loop-runner.py --mode tick` which in turn invokes the harness. The runner's fix is what makes the chain work end-to-end.
+
+## Cross-references checked
+
+- `rg "prompt-file|--cwd" design/ templates/ scripts/ contracts/ README.md AGENTS.md` — only intentional references remain (in the `design/loops/technical.md` explanatory text mentioning that the old default had no `--prompt-file` flag, and in the Pi Dev / generic examples that use `--cwd` as a user-chosen flag for their harness). No stale references.
+
+## Verdict
+
+PASS — proceed to referee.