Restore archived tasks, fix dashboard scroll-reset, bind ornith, add Playwright smoke test
- **Restore 82 completed tasks** from tasks/complete/ back to tasks/ top level (all <7 days old per the cleanup policy; premature bulk archive was fixed). - **Dashboard: fix scroll-reset on auto-refresh** — renderBoard rebuilds the board via innerHTML every 2s, destroying each column-body's scrollTop. Now snapshots column-body scrollTop + board.scrollLeft + view.scrollTop before rebuild and restores after (matched by PHASE_GROUPS index). - **Dashboard UI additions** (pre-existing unstaged work): approval section cards, transition buttons, inline artifact editor (textarea for writing missing SPEC/VERDICT/etc from the detail modal). - **Bind ornith as Implement model** — config.md: Model explicit to omlx/Ornith-1.0-35B-4bit-mlx, context window 32768. Interactive autopilot already used ornith via opencode default; now explicit. - **Fix cleanup stub** — automaton-cleanup.sh had a stale --project arg pointing at a pytest temp dir (test isolation leak). Rewired to point at ~/.automaton. - **Fix plist-isolation test** — test asserted host plist doesn't exist, but a real install creates it. Now snapshots mtime before run, asserts unchanged after (only a write during the test counts as bleed). - **New Playwright smoke test** (tests/test_dashboard_ui.py) — 2 tests: board renders tasks, column scroll survives auto-refresh tick. Verified the test fails without the scroll fix (scrollTop resets to 0). Skipped via importorskip when playwright is absent (main CI stays green). - **Clarify SI loop scope in README** — new-project onboarding section documents the framework-scoped self-improvement loop and options (leave/pause/create project loop). - **CHANGELOG** documents all changes including the known model-divergence gap (mde tasks marked complete but per-role model binding was never implemented).
This commit is contained in:
@@ -0,0 +1 @@
|
||||
complete
|
||||
@@ -0,0 +1,9 @@
|
||||
# Adversarial Bug Report: Centered Modal for Task Detail
|
||||
|
||||
## Deep Review
|
||||
Modal uses fixed positioning with backdrop blur. Close on backdrop click checks `e.target === e.currentTarget`.
|
||||
|
||||
## Potential Issues
|
||||
1. **Z-index stacking**: Modal overlay is z-index 100, help modal is z-index 200. If both open simultaneously, help modal overlays correctly.
|
||||
|
||||
## Verdict: PASS
|
||||
@@ -0,0 +1,18 @@
|
||||
# Bug Report: Centered Modal for Task Detail
|
||||
|
||||
## Methodology
|
||||
Reviewed dashboard.js, styles.css, index.html for modal behavior.
|
||||
|
||||
## Acceptance Criteria
|
||||
| # | Criterion | Result |
|
||||
|---|-----------|--------|
|
||||
| 1 | Centered with 720px max-width, 85vh max-height | ✅ |
|
||||
| 2 | Content scrollable | ✅ |
|
||||
| 3 | Backdrop click closes | ✅ |
|
||||
| 4 | Escape key closes | ✅ |
|
||||
| 5 | Existing functionality preserved | ✅ |
|
||||
|
||||
## Findings
|
||||
None.
|
||||
|
||||
## Verdict: PASS
|
||||
@@ -0,0 +1,11 @@
|
||||
# Doc Review: Centered Modal for Task Detail
|
||||
|
||||
## Documents Checked
|
||||
| Doc | Status |
|
||||
|-----|--------|
|
||||
| automaton/dashboard/README.md | ❌ Missing — no modal interaction docs |
|
||||
|
||||
## Findings
|
||||
1. **Missing**: Dashboard README doesn't document backdrop click or escape-to-close.
|
||||
|
||||
## Verdict: PASS (finding noted)
|
||||
@@ -0,0 +1,28 @@
|
||||
# Implementation: Centered Modal for Task Detail
|
||||
|
||||
## Summary
|
||||
|
||||
Replaced the narrow sliding side panel with a centered modal overlay for viewing task details.
|
||||
|
||||
## Changes Made
|
||||
|
||||
### `index.html`
|
||||
- Replaced `.detail-panel` fixed sidebar with `.modal-overlay` + `.modal-panel` container
|
||||
- Added `#btn-close-detail` button and backdrop click handler
|
||||
|
||||
### `dashboard.js`
|
||||
- Updated all JS references from `detail-panel` to `detail-overlay`
|
||||
- `closeDetail()` hides overlay instead of sliding panel
|
||||
- Escape key handler added for modal close
|
||||
- Backdrop click closes modal
|
||||
|
||||
### `styles.css`
|
||||
- `.modal-overlay` — fixed fullscreen backdrop with blur
|
||||
- `.modal-panel` — centered container, 720px max-width, 85vh max-height
|
||||
- Removed `.detail-panel` fixed positioning styles
|
||||
- Scrollable content within modal
|
||||
|
||||
## Files Modified
|
||||
- `automaton/dashboard/html/index.html` — modal overlay structure
|
||||
- `automaton/dashboard/html/dashboard.js` — modal open/close logic
|
||||
- `automaton/dashboard/html/styles.css` — modal styling
|
||||
@@ -0,0 +1,3 @@
|
||||
# Review
|
||||
- **Status**: approved
|
||||
- **Timestamp**: 2026-06-13T18:04:56.987626
|
||||
@@ -0,0 +1,24 @@
|
||||
# SPEC: Convert Task Detail Panel to Centered Modal
|
||||
|
||||
## Overview
|
||||
|
||||
The sliding side panel (380px wide) is too narrow to read SPEC.md, verdicts, and other task content. Replace it with a centered modal overlay that uses the full screen width.
|
||||
|
||||
## Changes
|
||||
|
||||
- Replace `.detail-panel` fixed sidebar with `.modal-overlay` + `.modal-panel`
|
||||
- Wrapped detail panel HTML in a modal overlay container
|
||||
- Added backdrop click to close
|
||||
- Updated JS references from `detail-panel` to `detail-overlay`
|
||||
|
||||
## Acceptance Criteria
|
||||
|
||||
- [ ] Modal is centered with 720px max width, 85vh max height
|
||||
- [ ] Content is scrollable within the modal
|
||||
- [ ] Clicking backdrop closes the modal
|
||||
- [ ] Escape key closes the modal
|
||||
- [ ] Existing functionality (review buttons, artifact display) is preserved
|
||||
|
||||
## VERDICT
|
||||
|
||||
PASS — implemented in commit 6630577
|
||||
@@ -0,0 +1,17 @@
|
||||
# VERDICT: Centered Modal for Task Detail
|
||||
|
||||
|
||||
## Status: PASS
|
||||
## Summary
|
||||
Replaced the narrow 380px side panel with a centered modal overlay (720px max-width) for task detail viewing.
|
||||
|
||||
## Phase Results
|
||||
| Phase | Result |
|
||||
|-------|--------|
|
||||
| Implementation | ✅ PASS |
|
||||
| Bug Find | ✅ PASS |
|
||||
| Adversarial Bug Find | ✅ PASS |
|
||||
| Doc Review | ✅ PASS (1 doc finding) |
|
||||
|
||||
## Final Verdict
|
||||
**PASS** — All acceptance criteria met.
|
||||
Reference in New Issue
Block a user